Review main Merged

50943[FOLLOWUP][TASK] Fluidification of ShortcutToolbarItem

Susi Moog CR +2 V +2 Easy +2 −2 updated 12/13/16, 09:23

Commit message

No changes to parameters in language labels are allowed therefore
a new label for the bookmark description is needed.

Review

  • Code review CR +2
    • Alexander Opitz +2
    • Wouter Wolters +1
  • Verified V +2
    • Alexander Opitz +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 67

  1. Susi Moog uploaded patch set 1 12/12/16, 20:19

  2. TYPO3com voted on patch set 1 V +1 12/12/16, 20:23 Completed build in 03m 46s on Mon, 12 Dec, 09:23 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5714

  3. Susi Moog commented on patch set 1 12/12/16, 20:28

    as alexander opitz mentioned in the original review we can't change parameters in existing labels, therefore I now renamed the label which hopefully means our translation servers can handle it.
  4. Wouter Wolters voted on patch set 1 CR +1 V +1 12/12/16, 20:59

  5. Alexander Opitz commented on patch set 1 12/12/16, 21:31

    Looks ok, will check tomorrow morning.
  6. Alexander Opitz voted on patch set 1 CR +2 V +2 12/13/16, 09:23

  7. Gerrit merged patch set 1 12/13/16, 09:23