50947[BUGFIX] Fix removed placeholders when non-admins publishes moved records
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 3947
Show 2022 earlier messages
-
Sven Hartmann uploaded patch set 1 12/13/16, 06:49
-
TYPO3com voted on patch set 1 V +1 12/13/16, 06:53 Completed build in 04m 06s on Tue, 13 Dec, 07:53 AM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5720
-
Tomas Norre Mikkelsen voted on patch set 1 CR +1 V +1 12/13/16, 07:17
-
Oliver Hader commented on patch set 1 CR -1 12/13/16, 20:36
* we need functional tests for this to ensure no other patch removes the functionality again * it has to be checked whether the bug is available for new records as well (without moving to a different location) -
Oliver Hader wrote 12/13/16, 20:38
Topic set to workspaces -
Uwe Trotzek voted on patch set 1 V +1 12/22/16, 12:38
-
Benni Mack commented on patch set 1 10/19/17, 21:25
ping -
Tomas Norre Mikkelsen commented on patch set 1 CR 0 V 0 11/30/17, 13:44
I can take care of writing tests for this one. -
Benni Mack commented on patch set 1 02/11/18, 00:13
ping -
Tomas Norre Mikkelsen commented on patch set 1 10/08/18, 14:20
Is this still relevant? Then I'll try to follow up on this. -
Josef Glatz commented on patch set 1 CR -1 10/09/18, 03:30
Commit Message „title“ needs to be shortened -
Tomas Norre Mikkelsen updated the commit message in patch set 2 10/09/18, 17:10
-
Tomas Norre Mikkelsen commented on patch set 2 CR -1 10/09/18, 17:12
Something went wrong with the update messages, the Releases is currently wrong.. Wanted : master,9.5,8.7,7.6,6.2 Think 6.2 can be dropped I think. Can someone please help with fixing the Releases? I changed it be commit --amend while updating the Commit message. FYI: Testing are still failing as Oliver Harder requested earlier. -
Wouter Wolters updated the commit message in patch set 3 10/09/18, 17:13
-
Tomas Norre Mikkelsen updated the commit message in patch set 4 10/09/18, 17:13
-
Wouter Wolters commented on patch set 3 10/09/18, 17:14
7.6 is only in critical bugfix mode, 6.2 is EOL already and only supported via ELTS. -
Wouter Wolters updated the commit message in patch set 5 10/09/18, 17:14
-
Tomas Norre Mikkelsen commented on patch set 4 10/09/18, 17:14
Thanks Wouter, didn't see you were on it.. Tried fixin it my self too.. Looks like i didn't damaged anything. -
Wouter Wolters commented on patch set 5 10/09/18, 17:15
@thomas please do not set 9.5 as version. We did not branch of yet -
Tomas Norre Mikkelsen commented on patch set 5 10/09/18, 17:16
Isn't 9.5 Missing? or is that master till a version 10.x is started? -
Tomas Norre Mikkelsen commented on patch set 5 10/09/18, 17:16
I see, thanks. -
TYPO3com voted on patch set 2 V +1 10/09/18, 17:23 Completed build in 12m 34s on Tue, 9 Oct, 07:23 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29381
-
TYPO3com voted on patch set 3 V +1 10/09/18, 17:27 Completed build in 14m 17s on Tue, 9 Oct, 07:27 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29382
-
TYPO3com voted on patch set 4 V +1 10/09/18, 17:31 Completed build in 14m 45s on Tue, 9 Oct, 07:31 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29383
-
TYPO3com voted on patch set 5 V +1 10/09/18, 17:36 Completed build in 19m 47s on Tue, 9 Oct, 07:36 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29384
-
Tymoteusz Motylewski commented on patch set 5 10/11/18, 07:54
I don't get the commit message. Does this patch make TYPO3 keep placeholders after publishing or not? Please use imperative mood for commit message title. see https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Appendix/CommitMessage.html#commitmessage If in doubt, the golden rule to follow is very simple: Review your subject lines, and apply the following words in front of it: if applied, this commit will **"your subject line here"** e.g. If applied, this commit will **"Fix backend edit URL in admin panel"** Reads nicely and explains what happened -
Tymoteusz Motylewski voted on patch set 5 CR -1 10/11/18, 07:54
-
Tomas Norre Mikkelsen updated the commit message in patch set 6 10/11/18, 15:30
-
TYPO3com voted on patch set 6 V +1 10/11/18, 15:41 Completed build in 10m 35s on Thu, 11 Oct, 05:41 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29426
-
Benni Mack voted on patch set 6 CR +1 10/30/18, 22:12
-
Benni Mack updated the commit message in patch set 7 12/14/18, 10:06
-
Benni Mack voted on patch set 7 CR +1 12/14/18, 10:06
-
TYPO3com voted on patch set 7 V +1 12/14/18, 11:25 Completed build in 29m 58s on Fri, 14 Dec, 12:25 PM Test Summary: 48757 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30701
-
Josef Glatz wrote 01/24/19, 06:16
Removed reviewer Josef Glatz. -
Uwe Trotzek commented on patch set 7 01/30/19, 12:47
Sorry for the very late response but I missed the update E-Mails of this issue for some reason. Since https://forge.typo3.org/issues/72556 the default value of tt_content => list_type is now set properly the error is not reproducible in TYPO3 >= 8.7 anymore. -
Oliver Hader commented on patch set 7 01/30/19, 16:04
Sounds like we should prove that by additional functional tests for admins and non-admins. Besides that, wouldn't list_type apply to new shadow placeholders as well? -
Oliver Hader commented on patch set 7 CR -1 01/30/19, 16:07
... tests, especially since Uwe mentioned it's not reproducible anymore since TYPO3 v8 -
Uwe Trotzek commented on patch set 7 01/31/19, 07:45
I pasted the wrong issue. This one fixed it: https://forge.typo3.org/issues/72171 Yes, new placeholder are affected as well. Currently I have no TYPO3 core testing environment. I will try to set it up and try to provide functional tests for this one to be safe for the future. -
Anja Leichsenring commented on patch set 7 05/19/19, 07:49
this patch could use some attention? Please move it out of the dusty stalled place it is currently in. -
Wouter Wolters wrote 06/04/19, 13:15
Removed reviewer Wouter Wolters. -
Anja Leichsenring wrote 09/09/19, 08:41
Removed reviewer Anja Leichsenring. -
Benni Mack updated the commit message in patch set 8 05/25/20, 18:41
-
TYPO3com voted on patch set 8 V +1 05/25/20, 18:59 Completed build in 18m 27s on Mon, 25 May, 06:59 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3522
-
Daniel Haupt commented on patch set 8 08/09/20, 19:55
I can not reproduce the problem this patch is trying to solve. I have moved and published a record of a draft workspace as non-admin but the placeholder record was removed. -
Uwe Trotzek commented on patch set 8 08/10/20, 07:18
> Patch Set 8: > > I can not reproduce the problem this patch is trying to solve. I have moved and published a record of a draft workspace as non-admin but the placeholder record was removed. Yes, the problem is not reproducible anymore (which is goot). I promised to provide functional tests to make sure this issue wont show up in the future. I hope I can make it this week. :) -
Oliver Hader commented on patch set 8 12/04/20, 16:25
In case I did understand it correctly, there is no bug anymore that needs to be solved, correct?! -
Benni Mack abandoned the change 10/21/21, 14:36
Abandoning this change as this has been stalled for over a year and the issue does not exist in v11 anymore (as we finally got rid of the option).