Review main Merged

50948[BUGFIX] setPartialRootPaths in the backend tabs menu

Alexander Opitz CR +2 V +2 Easy +10 −4 updated 12/20/16, 12:17

Commit message

Adding the root paths to the partials, which aren't autoguessed anymore.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Mathias Schreiber +1
    • Susi Moog +1
  • Verified V +2
    • Oliver Hader +2
    • Mathias Schreiber +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1518

  1. Alexander Opitz uploaded patch set 1 12/13/16, 09:20

  2. TYPO3com voted on patch set 1 V +1 12/13/16, 09:24 Completed build in 04m 16s on Tue, 13 Dec, 10:24 AM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5723

  3. Alexander Opitz commented on patch set 1 12/13/16, 09:26

    In the issue is a patch to test the behavior which I found while porting TemplaVoila
  4. Susi Moog commented on patch set 1 12/13/16, 09:32

    AbstractContainer.php:84

    please rename the var to templatePath (as it does not contain the fileName anymore).

    AbstractContainer.php:89

    should we also set Layout Path?

    ModuleTemplate.php:453

    see comments in other file.
  5. Alexander Opitz uploaded patch set 2 12/13/16, 09:41

  6. Alexander Opitz commented on patch set 1 12/13/16, 09:42

    AbstractContainer.php:84 Reply

    Done

    AbstractContainer.php:89 Reply

    Layout isn't used in this area.

    ModuleTemplate.php:453 Reply

    Done
  7. TYPO3com voted on patch set 2 V +1 12/13/16, 09:44 Completed build in 03m 20s on Tue, 13 Dec, 10:44 AM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5725

  8. Oliver Hader commented on patch set 2 12/20/16, 10:58

    I had the same thoughts about "Layout". Even if it's not used currently in the core, it would be possible that extensions make use of it, right?
  9. Oliver Hader commented on patch set 2 12/20/16, 11:18

    After discussing with Alex, Layout indeed is not required here...
  10. Oliver Hader commented on patch set 2 12/20/16, 11:19

    Testes with NewContentElementController and FlexFormTabsContainer
  11. Oliver Hader uploaded patch set 3 12/20/16, 11:25

  12. Oliver Hader voted on patch set 3 CR +1 V +1 12/20/16, 11:25

  13. TYPO3com voted on patch set 3 V +1 12/20/16, 11:29 Completed build in 04m 10s on Tue, 20 Dec, 12:29 PM Test Summary: 54399 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5885

  14. Mathias Schreiber voted on patch set 3 CR +1 V +1 12/20/16, 11:33

  15. Susi Moog voted on patch set 3 CR +1 12/20/16, 11:33

  16. Susi Moog voted on patch set 3 V +1 12/20/16, 11:35

  17. Oliver Hader commented on patch set 3 CR +2 V +2 12/20/16, 12:17

    Thx!
  18. Gerrit merged patch set 3 12/20/16, 12:17