Review main Abandoned

50951[BUGFIX] Avoid duplicates in processing of remapStack

Claus Due CR 0 V 0 Easy +25 −5 updated 11/26/17, 17:30

Commit message

By filtering the remap stack in the DataHandler before iterating it
we can avoid potentially duplicate calls to perform the same
operation on the same record. This ensures amongst others that the
hook processDatamap_afterDatabaseOperations is not processed more
than once.

The filtering occurs in filterRemapStack using a Generator.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 3039

Show 1014 earlier messages
  1. Claus Due uploaded patch set 1 12/13/16, 14:26

  2. TYPO3com voted on patch set 1 V -1 12/13/16, 14:30 Completed build in 03m 40s on Tue, 13 Dec, 03:30 PM Test Summary: 344 of 54373 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5735

  3. Claus Due uploaded patch set 2 12/13/16, 14:34

  4. Claus Due uploaded patch set 3 12/13/16, 14:39

  5. TYPO3com voted on patch set 2 V +1 12/13/16, 14:39 Completed build in 05m 41s on Tue, 13 Dec, 03:39 PM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5738

  6. TYPO3com voted on patch set 3 V +1 12/13/16, 14:43 Completed build in 04m 02s on Tue, 13 Dec, 03:43 PM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5739

  7. Mads Lønne Jensen commented on patch set 3 12/14/16, 13:10

    DataHandler.php:5948

    We probably want to set the "strict" flag for in_array.

    DataHandler.php:5951

    This part (line 5951-5993) should be under processRemapStack, it has nothing to do with filtering duplicates
  8. Claus Due commented on patch set 3 12/14/16, 13:35

    DataHandler.php:5948 Reply

    10-4

    DataHandler.php:5951 Reply

    Will solve this by renaming the method - the refactoring into "filter/translate values" and "iterate/execute operations" still makes sense imho, but like you said, no longer deals just with duplicates.
  9. Thomas Hohn voted on patch set 3 V +1 12/16/16, 06:02

  10. Thomas Hohn commented on patch set 3 CR -1 V -1 01/29/17, 13:19

    Hi Claus - did an analysis of the "before" and after results - and there seems to be created som "weird" record - i'll dig into it and see that the problem is...
  11. Thomas Hohn uploaded patch set 4 01/29/17, 15:47

  12. Thomas Hohn commented on patch set 4 CR +1 V +1 01/29/17, 15:53

    My bad Claus - seems to work as expected - added som documentation to the new method
  13. TYPO3com voted on patch set 4 V +1 01/29/17, 15:53 Completed build in 06m 34s on Sun, 29 Jan, 04:53 PM Test Summary: 55655 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7184

  14. Thomas Hohn updated the commit message in patch set 5 01/29/17, 15:54

  1. TYPO3com voted on patch set 5 V +1 01/29/17, 15:59 Completed build in 05m 28s on Sun, 29 Jan, 04:59 PM Test Summary: 55655 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7185

  2. Thomas Hohn voted on patch set 5 CR +1 V +1 01/29/17, 16:10

  3. Thomas Hohn commented on patch set 5 V -1 02/02/17, 06:59

    Seems to have some kind of side-effect that should be investigated further
  4. Thomas Hohn commented on patch set 5 CR 0 V 0 02/03/17, 13:20

    Error in my setup - this one is ok!
  5. Thomas Hohn commented on patch set 5 V -1 02/03/17, 13:22

    Hitting wrong ticket - need to look into this one again
  6. Thomas Hohn uploaded patch set 6 02/04/17, 10:04

  7. Thomas Hohn uploaded patch set 7 02/04/17, 10:06

  8. TYPO3com voted on patch set 6 V -1 02/04/17, 10:11 Completed build in 06m 47s on Sat, 4 Feb, 11:11 AM Test Summary: 46953 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7451

  9. TYPO3com voted on patch set 7 V +1 02/04/17, 10:13 Completed build in 06m 34s on Sat, 4 Feb, 11:13 AM Test Summary: 55901 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7452

  10. Philipp Gampe voted on patch set 7 CR +1 02/04/17, 10:25

  11. Stephan Großberndt updated the commit message in patch set 8 02/04/17, 10:35

  12. TYPO3com voted on patch set 8 V +1 02/04/17, 10:40 Completed build in 04m 57s on Sat, 4 Feb, 11:40 AM Test Summary: 55901 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7454

  13. Claus Due voted on patch set 8 CR +1 02/28/17, 10:48

  14. Kasper Ligaard voted on patch set 8 CR +1 03/04/17, 09:20

  15. Thomas Hohn updated the commit message in patch set 9 04/18/17, 06:42

  16. TYPO3com voted on patch set 9 V +1 04/18/17, 07:09 Completed build in 26m 12s on Tue, 18 Apr, 09:09 AM Test Summary: 56618 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10648

  17. Kasper Ligaard voted on patch set 9 CR +1 05/02/17, 14:29

  18. Kasper Ligaard commented on patch set 9 05/04/17, 19:53

    Ping.
  19. Kasper Ligaard commented on patch set 9 V +1 05/22/17, 20:55

    Just needs core developer to merge :-)
  20. Kasper Ligaard commented on patch set 9 06/08/17, 12:33

    ping
  21. Thomas Hohn voted on patch set 9 CR +1 V +1 06/19/17, 08:27

  22. Kasper Ligaard commented on patch set 9 07/01/17, 11:10

    Only needs a core developer to merge :-)
  23. Oliver Hader commented on patch set 9 CR -1 11/24/17, 22:48

    In terms of performance this has been solved already with https://review.typo3.org/51552 which the hook is only executed for one record per table. The previous processing happens on a per-field basis - thus I don't see a strong demand for this very patch anymore. What do you think?
  24. Thomas Hohn commented on patch set 9 CR 0 V 0 11/26/17, 08:23

    I agree that we could/can skip this patch
  25. Claus Due abandoned the change 11/26/17, 17:30

    Agreed; performance was the reason for creating this and the other patch obtains the same benefit.