50953[BUGFIX] Optimize cache handling in ReflectionService
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Stefan Rotsch +1
- Tymoteusz Motylewski +1
-
Verified V +2
- Markus Klein +2
- Stefan Rotsch +1
- Tymoteusz Motylewski +1
- TYPO3com +1 CI
Issues 2
Files 1
Review log 2936
Show 911 earlier messages
-
Stefan Rotsch uploaded patch set 1 12/13/16, 22:44
-
TYPO3com voted on patch set 1 V -1 12/13/16, 22:48 Completed build in 03m 36s on Tue, 13 Dec, 11:48 PM Test Summary: 54393 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5749
-
Markus Klein commented on patch set 1 12/13/16, 23:29
affects 7.6 too, at least! -
Stefan Rotsch uploaded patch set 2 12/14/16, 08:47
-
TYPO3com voted on patch set 2 V +1 12/14/16, 08:51 Completed build in 03m 51s on Wed, 14 Dec, 09:51 AM Test Summary: 54393 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5751
-
Wouter Wolters commented on patch set 2 12/14/16, 09:30
ReflectionServiceTest.php:49needs to be protected.ReflectionServiceTest.php:53we should use the ::class construct here in makeInstance and objectmanagerReflectionServiceTest.php:68::classReflectionServiceTest.php:72We need to use the doctrine API here. databaseConnection is deprecated.ReflectionServiceTest.php:84::class -
Xavier Perseguers voted on patch set 2 V +1 12/14/16, 09:58
-
Oliver Klee commented on patch set 2 12/14/16, 12:06
MethodReflection.php:33I propose adding a PHP 7 return type. -
Andreas Kienast commented on patch set 2 12/14/16, 12:13
MethodReflection.php:33ReplyI suggest not to do this for bugfixes that are intended to get backported. -
Markus Klein commented on patch set 2 12/14/16, 12:43
Do we backport the tests as well? Otherwise I would make this file PHP7 strict -
Helmut Hummel commented on patch set 2 12/14/16, 12:55
ReflectionServiceTest.php:72ReplyWe shouldn't look into the database at all, but find a way to assert a cache entry has been created
-
Helmut Hummel commented on patch set 2 12/14/16, 12:57
ReflectionServiceTest.php:72Replyor remove these assertions completely -
Stefan Rotsch uploaded patch set 3 12/14/16, 17:24
-
TYPO3com voted on patch set 3 V +1 12/14/16, 17:28 Completed build in 03m 48s on Wed, 14 Dec, 06:28 PM Test Summary: 54393 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5757
-
Stefan Rotsch commented on patch set 2 12/14/16, 17:29
I've addressed Wouters comments (sorry, the project I'm on is still based on 6.2, so there is a lot of new stuff for me to learn) Regarding Helmuts comments, I agree it is not ideal to check for the creation of a cache record by looking into the DB. Have to think about how to modify the test… -
Helmut Hummel commented on patch set 3 CR -1 V -1 12/14/16, 23:20
MethodReflection.php:35this is definitely wrong! __sleep must return an array of properties not a string. this completely breaks serialization of these objects -
Helmut Hummel commented on patch set 3 12/14/16, 23:41
btw. your patch works because the serialization is invalid and an unserialize returns null, thus the reflection service builds a new object. This is not a solution. we must either find out why the objects are broken after unserialize or remove the reflection change again and see how to avoid duplicate caching otherwise -
Helmut Hummel commented on patch set 3 CR -2 12/14/16, 23:57
We need to revert the patch that caused the troubles and find another solution for the problem -
Helmut Hummel uploaded patch set 4 12/15/16, 00:39
-
Helmut Hummel commented on patch set 4 CR 0 12/15/16, 00:40
I re-wrote the reflection service to fix both issues at hand please carefully test and the backport to the other branches -
TYPO3com voted on patch set 4 V +1 12/15/16, 00:44 Completed build in 04m 14s on Thu, 15 Dec, 01:44 AM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5772
-
Helmut Hummel uploaded patch set 5 12/15/16, 00:51
-
TYPO3com voted on patch set 5 V -1 12/15/16, 00:55 Completed build in 03m 34s on Thu, 15 Dec, 01:55 AM Test Summary: 1162 of 54391 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5773
-
Markus Klein commented on patch set 5 12/15/16, 01:23
composer.lock needs to be updated I guess (composer.json hash) -
Markus Klein commented on patch set 5 CR -1 12/15/16, 01:26
ReflectionService.php:319by reading this change is not necessary, I would say.ReflectionService.php:575can you explain why this is always needed?frontend.php:33test-code that should go away I guess -
Helmut Hummel commented on patch set 5 12/15/16, 02:11
ReflectionService.php:319Replytrue, it just alligns with the other codeReflectionService.php:575Replycreating a reflection might cause an exception, which still needs to cause the cache to be re-written. also this is called from several places and every time it is called, the cache needs update. check the calling codefrontend.php:33ReplyDone -
Helmut Hummel uploaded patch set 6 12/15/16, 02:11
-
TYPO3com voted on patch set 6 V +1 12/15/16, 02:15 Completed build in 04m 16s on Thu, 15 Dec, 03:15 AM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5774
-
Nicole Hummel uploaded patch set 7 12/15/16, 08:43
-
TYPO3com voted on patch set 7 V +1 12/15/16, 08:48 Completed build in 04m 51s on Thu, 15 Dec, 09:48 AM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5777
-
Tymoteusz Motylewski voted on patch set 7 CR +1 V +1 12/15/16, 09:15
-
Markus Klein commented on patch set 7 CR +1 12/15/16, 09:41
Thanks for explanation -
Stefan Rotsch voted on patch set 7 CR +1 V +1 12/15/16, 09:50
-
Markus Klein voted on patch set 7 V +1 12/15/16, 12:25
-
Markus Klein voted on patch set 7 CR +2 V +2 12/15/16, 23:11
-
Gerrit merged patch set 7 12/15/16, 23:11