Review main Abandoned

50959[BUGFIX] rawurlencode()'d record titles using label_alt and type=group

Stephan Großberndt CR 0 V 0 Easy +1 −1 updated 10/27/17, 13:03

Commit message

rawurldecode() the label_alt part references of record titles if they
are of type=group.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 67

  1. Stephan Großberndt uploaded patch set 1 12/14/16, 16:25

  2. TYPO3com voted on patch set 1 V +1 12/14/16, 16:29 Completed build in 03m 57s on Wed, 14 Dec, 05:29 PM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5756

  3. Helmut Hummel commented on patch set 1 12/14/16, 20:50

    TcaRecordTitle.php:246

    we should rather find the place where this is encoded and do not encode it there
  4. Stephan Großberndt commented on patch set 1 12/14/16, 21:36

    TcaRecordTitle.php:246 Reply

    That would be \TYPO3\CMS\Backend\Form\FormDataProvider\TcaGroup::addData(), where \TYPO3\CMS\Core\Database\RelationHandler::readyForInterface is called which does the encoding.
  5. Stephan Großberndt commented on patch set 1 10/27/17, 13:02

    New patch in 54483
  6. Stephan Großberndt commented on patch set 1 10/27/17, 13:02

  7. Stephan Großberndt abandoned the change 10/27/17, 13:03