Review main Abandoned

50960[TASK] Make the default value of TCA fields translatable

Georg Ringer CR 0 V 0 Normal +69 −2 updated 10/18/17, 18:01

Commit message

The value of the default field should be translatable.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1521

  1. Georg Ringer uploaded patch set 1 12/14/16, 19:11

  2. TYPO3com voted on patch set 1 V -1 12/14/16, 19:15 Completed build in 04m 14s on Wed, 14 Dec, 08:15 PM Test Summary: 12 of 54391 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5759

  3. Christian Kuhn commented on patch set 1 12/14/16, 19:35

    DatabaseRowDefaultValues.php:58

    ok to remove this comment ... gave that some thoughts lately, and YES, it is a good idea to have that initialized in databaseRow as empty string.

    DatabaseRowDefaultValues.php:59

    fine with me to add this feature, but please add a unit test that the translation is actually called. you should find some example in some other data providers that prophecize the language service.

    DatabaseRowDefaultValues.php:74

    you could easily declace_strict=1 for this class and add a string return value type hint on this method, add this to the unit test of that class, too.
  4. Georg Ringer uploaded patch set 2 12/15/16, 06:44

  5. TYPO3com voted on patch set 2 V +1 12/15/16, 06:49 Completed build in 04m 13s on Thu, 15 Dec, 07:49 AM Test Summary: 54397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5775

  6. Mathias Brodala commented on patch set 2 CR -1 12/15/16, 08:32

    DatabaseRowDefaultValuesTest.php:44

    This line should be moved down to the test and made specific (argument "foo").

    DatabaseRowDefaultValuesTest.php:172

    See above.
  7. Georg Ringer uploaded patch set 3 12/15/16, 13:55

  8. TYPO3com voted on patch set 3 V +1 12/15/16, 14:01 Completed build in 06m 09s on Thu, 15 Dec, 03:01 PM Test Summary: 54397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5790

  9. Georg Ringer uploaded patch set 4 04/26/17, 21:12

  10. TYPO3com voted on patch set 4 V -1 04/26/17, 21:19 Completed build in 06m 45s on Wed, 26 Apr, 11:19 PM Test Summary: 55788 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11001

  11. Benni Mack commented on patch set 4 09/09/17, 21:39

    ping
  12. Georg Ringer rebased onto patch set 5 09/18/17, 08:02

  13. TYPO3com voted on patch set 5 V -1 09/18/17, 08:02 Completed build in 09s on Mon, 18 Sep, 10:02 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14996

  14. Jörg Bösche uploaded patch set 6 09/18/17, 08:17

  15. TYPO3com voted on patch set 6 V +1 09/18/17, 08:32 Completed build in 14m 28s on Mon, 18 Sep, 10:32 AM Test Summary: 58200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14997

  16. Christian Kuhn commented on patch set 6 CR -1 10/17/17, 23:08

    don't get it. you're adding context to be user for adding new records: a BE user sets his BE to english, creates a record, then sets his BE to french and gets different default values for new records in DB? rly?
  17. Georg Ringer commented on patch set 6 10/18/17, 06:49

    yes really. Same as with translateToMessage which also works the same. Funny you had no problem months ago
  18. Mathias Brodala commented on patch set 6 10/18/17, 07:26

    IMHO it would make sense to translate the default value based on the record language, not the user language.
  19. Georg Ringer commented on patch set 6 10/18/17, 11:40

    we don't do that anywhere that way
  20. Mathias Brodala commented on patch set 6 10/18/17, 11:54

    > we don't do that anywhere that way So what? ;-) I'd vote for doing things in a way they make sense, not only how they've been done before.
  21. Georg Ringer abandoned the change 10/18/17, 18:01

    rly not needed. thx 4 the fish