Review main Merged

50963Revert "[BUGFIX] Reflection Cache does not save methodReflections"

Helmut Hummel CR +2 V +2 Easy +0 −1 updated 12/15/16, 09:52

Commit message

Internal PHP classes including the \ReflectionMethod are not serlializable. Doing so results in a fatal error at some point.
The reported issue must be solved differently.

This reverts commit a5c1e222bf9858f5a44af1007cd9e1677b9a534d.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Markus Klein +1
  • Verified V +2
    • Nicole Hummel +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1114

  1. Helmut Hummel uploaded patch set 1 12/15/16, 00:20

  2. Helmut Hummel updated the commit message in patch set 2 12/15/16, 00:21

  3. TYPO3com voted on patch set 1 V +1 12/15/16, 00:25 Completed build in 05m 15s on Thu, 15 Dec, 01:25 AM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5770

  4. TYPO3com voted on patch set 2 V +1 12/15/16, 00:26 Completed build in 04m 56s on Thu, 15 Dec, 01:26 AM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5771

  5. Markus Klein commented on patch set 2 CR -1 12/15/16, 01:22

    I guess this is superfluous with your other fix?
  6. Helmut Hummel commented on patch set 2 12/15/16, 02:12

    i personally think it is clearer to revert this first
  7. Markus Klein commented on patch set 2 CR 0 12/15/16, 08:45

    fine with me
  8. Markus Klein updated the commit message in patch set 3 12/15/16, 08:45

  9. Markus Klein voted on patch set 3 CR +1 V +1 12/15/16, 08:46

  10. Nicole Hummel voted on patch set 3 CR +2 V +2 12/15/16, 08:48

  11. TYPO3com voted on patch set 3 V +1 12/15/16, 08:50 Completed build in 04m 42s on Thu, 15 Dec, 09:50 AM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5778

  12. Nicole Hummel commented on patch set 3 12/15/16, 08:53

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 21fca817a205760bf58eb90eebd10c7a88c56a54
  13. Gerrit merged patch set 3 12/15/16, 08:56

  14. Nicole Hummel commented on patch set 4 12/15/16, 09:52

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 3fca8fa7d96a8dded16664b1fd501bedc130c891