Review main Merged

50970[BUGFIX] Avoid live ID processing if EXT:version not loaded

Claus Due CR +2 V +2 Easy +4 −0 updated 03/27/17, 20:13

Commit message

DataHandler does not need to force "live ID" processing to
be enabled on RelationHandler when EXT:version is not loaded.

Avoiding this saves some semi-expensive operations inside
the RelationHandler class.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Claus Due +1
    • Thomas Hohn +1
    • Wouter Wolters +1
  • Verified V +2
    • Oliver Hader +2
    • Thomas Hohn +1
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2935

Show 910 earlier messages
  1. Claus Due uploaded patch set 1 12/15/16, 10:25

  2. Claus Due commented on patch set 1 12/15/16, 10:26

    FYI: can be backported to 7.6 without conflicts.
  3. TYPO3com voted on patch set 1 V +1 12/15/16, 10:30 Completed build in 04m 55s on Thu, 15 Dec, 11:30 AM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5780

  4. Thomas Hohn voted on patch set 1 CR +1 V +1 12/16/16, 06:00

  5. Christian Müllenhagen commented on patch set 1 12/16/16, 09:25

    DataHandler.php:3106

    This is a typo, right? Should be 'version'. And better move to constant.
  6. Andreas Kienast commented on patch set 1 12/16/16, 09:35

    DataHandler.php:3863

    version
  7. Oliver Hader commented on patch set 1 CR -1 V -1 12/16/16, 13:06

    What's the benefit in these changes? Which bug/misbehavior shall be solved? Since "version" is spelled wrong in this patch twice the negation of the check results into TRUE which is exactly the default value of the variable in RelationHandler - thus, this change is actually not a change at all
  8. Claus Due commented on patch set 1 12/16/16, 14:49

    > What's the benefit in these changes? Performance improvement. Switching an always-performed SQL query to only being performed when versions are enabled. > Which bug/misbehavior shall be solved? Performance issues in particular in large record copy/import/export operations.
  9. Claus Due uploaded patch set 2 12/16/16, 14:51

  10. Claus Due commented on patch set 2 12/16/16, 14:51

    Fixed typos
  1. TYPO3com voted on patch set 2 V -1 12/16/16, 14:55 Completed build in 04m 16s on Fri, 16 Dec, 03:55 PM Test Summary: 186 of 54391 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5826

  2. Claus Due uploaded patch set 3 12/22/16, 09:03

  3. Claus Due commented on patch set 3 12/22/16, 09:04

    Removed incorrect negation. Live IDs must be used when "version" is loaded, not when it isn't loaded.
  4. TYPO3com voted on patch set 3 V +1 12/22/16, 09:08 Completed build in 04m 21s on Thu, 22 Dec, 10:08 AM Test Summary: 54399 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5919

  5. Thomas Hohn commented on patch set 3 CR +1 V +1 12/22/16, 10:12

    DataHandler.php:3863

    Then this would be a typo too :-(
  6. Claus Due uploaded patch set 4 02/23/17, 18:21

  7. Thomas Hohn voted on patch set 4 CR +1 V +1 02/23/17, 18:26

  8. TYPO3com voted on patch set 4 V -1 02/23/17, 18:30 Completed build in 09m 12s on Thu, 23 Feb, 07:30 PM Test Summary: 186 of 56456 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8423

  9. Oliver Hader commented on patch set 4 CR -1 02/28/17, 11:42

    If EXT:version is loaded, the live-id processing is disabled, but that's not how workspace overlays are supposed to work in the core. There are some rare cases (look into DataHandler and ReferenceIndex) where the specific version ids are used, e.g. for dealing with MM-relations in workspaces.
  10. Oliver Hader voted on patch set 4 V -1 02/28/17, 11:42

  11. Claus Due commented on patch set 4 02/28/17, 11:47

    > but that's not how workspace overlays are supposed to work in the core. Pardon me, but you can't do workspace overlays without EXT:version loaded, so attempting to do non-live-ID processing when EXT:version is not loaded, is a logical inconsistency. Either that, or an undocumented, too-tightly-coupled dependency (which we ALSO should solve by checking if EXT:version is loaded). Right...?
  12. Claus Due commented on patch set 4 02/28/17, 11:48

    In fact, you can't switch to any workspaces if EXT:workspace is not installed and EXT:workspace cannot be installed if EXT:version is not also installed...
  13. Oliver Hader commented on patch set 2 02/28/17, 13:05

    The way the patch is implemented currently should be faster, is that correct? How did you measure that?
  14. Thomas Hohn uploaded patch set 5 02/28/17, 15:52

  15. TYPO3com voted on patch set 5 V +1 02/28/17, 16:01 Completed build in 09m 09s on Tue, 28 Feb, 05:01 PM Test Summary: 56309 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8759

  16. Thomas Hohn commented on patch set 5 CR +1 V +1 02/28/17, 16:05

    Good catch Olly - the negation shouldn't have been there :-)
  17. Oliver Hader commented on patch set 5 02/28/17, 18:19

    Exactly, the patch as it was could never have been faster...
  18. Oliver Hader uploaded patch set 6 02/28/17, 18:19

  19. Thomas Hohn voted on patch set 6 CR +1 02/28/17, 18:28

  20. TYPO3com voted on patch set 6 V +1 02/28/17, 18:29 Completed build in 09m 48s on Tue, 28 Feb, 07:29 PM Test Summary: 56321 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8769

  21. Claus Due voted on patch set 6 CR +1 03/16/17, 16:06

  22. Thomas Hohn voted on patch set 6 V +1 03/27/17, 19:11

  23. Wouter Wolters voted on patch set 6 CR +1 V +1 03/27/17, 20:12

  24. Oliver Hader voted on patch set 6 CR +2 V +2 03/27/17, 20:13

  25. Gerrit merged patch set 6 03/27/17, 20:13