50976[CLEANUP] Simplify updating of timestamp in writeForeignField
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Philipp Gampe +1
-
Verified V +2
- Andreas Kienast +2
- Philipp Gampe +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1214
-
Claus Due uploaded patch set 1 12/15/16, 13:37
-
TYPO3com voted on patch set 1 V +1 12/15/16, 13:42 Completed build in 04m 50s on Thu, 15 Dec, 02:42 PM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5786
-
Thomas Hohn commented on patch set 1 CR +1 V +1 12/16/16, 05:57
Looks fine to me -
Oliver Klee commented on patch set 1 12/31/16, 15:00
If I understand this correctly, this isn't a bug fix as the current behavior is not wrong, but just not very effective. So it should be more of a TASK or CLEANUP. -
Claus Due commented on patch set 1 01/14/17, 00:24
> If I understand this correctly, this isn't a bug fix as the current behavior is not wrong, but just not very effective. So it should be more of a TASK or CLEANUP. I'm addressing performance problems as bugs which is why this (and other same-topic) use the BUGFIX prefix. Technically speaking, performance degradation is a bug if performance is a feature ;) -
Thomas Hohn updated the commit message in patch set 2 01/29/17, 07:29
-
TYPO3com voted on patch set 2 V +1 01/29/17, 07:34 Completed build in 04m 47s on Sun, 29 Jan, 08:34 AM Test Summary: 55619 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7175
-
Andreas Kienast voted on patch set 2 CR +1 01/29/17, 08:09
-
Andreas Kienast voted on patch set 2 V +1 01/29/17, 08:34
-
Philipp Gampe voted on patch set 2 CR +1 01/29/17, 09:28
-
Philipp Gampe voted on patch set 2 V +1 01/29/17, 10:46
-
Andreas Kienast voted on patch set 2 CR +2 V +2 01/29/17, 11:15
-
Gerrit merged patch set 2 01/29/17, 11:15
-
Andreas Kienast commented on patch set 3 01/29/17, 11:16
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit bc8ff7a7ced115e470bc338d68cdecfc9fb75f24