Review main Merged

50977[BUGFIX] Add default values from setup.txt and raise override to 20

Boris Schauer CR +2 V +2 Easy +4 −2 updated 12/20/16, 19:12

Commit message

Update the indexed_search extension documentation with
proper TypoScript values for overriding templates.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Mathias Schreiber +1
    • Stephan Großberndt +1
    • Benni Mack +1
  • Verified V +2
    • Wouter Wolters +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1013

  1. Boris Schauer uploaded patch set 1 12/15/16, 13:37

  2. TYPO3com voted on patch set 1 V +1 12/15/16, 13:42 Completed build in 04m 53s on Thu, 15 Dec, 02:42 PM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5787

  3. Harry Glatz updated the commit message in patch set 2 12/15/16, 14:09

  4. TYPO3com voted on patch set 2 V +1 12/15/16, 14:13 Completed build in 03m 49s on Thu, 15 Dec, 03:13 PM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5793

  5. Benni Mack updated the commit message in patch set 3 12/15/16, 14:27

  6. Benni Mack voted on patch set 3 CR +1 12/15/16, 14:27

  7. TYPO3com voted on patch set 3 V +1 12/15/16, 14:31 Completed build in 03m 36s on Thu, 15 Dec, 03:31 PM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5795

  8. Stephan Großberndt voted on patch set 3 CR +1 12/15/16, 17:22

  9. Mathias Schreiber voted on patch set 3 CR +1 V +1 12/17/16, 16:48

  10. Nicole Hummel commented on patch set 3 12/18/16, 20:47

    Index.rst:22

    Isn't this the same as 0?

    Index.rst:28

    see above
  11. Wouter Wolters commented on patch set 3 CR +2 V +2 12/20/16, 19:07

    No, this is not the same as the constants are by default empty.
  12. Gerrit merged patch set 3 12/20/16, 19:07

  13. Wouter Wolters commented on patch set 4 12/20/16, 19:12

    No backport to 7.6 possible here, the documentation is not there in 7.6.