5098[TASK] EM: cleanup phpDoc and fix type hints
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
-
Verified V +2
- Xavier Perseguers +2
Issues 1
Files 15
- typo3/sysext/em/classes/connection/class.tx_em_connection_extdirectserver.php+18 −22
- typo3/sysext/em/classes/import/class.tx_em_import_mirrorlistimporter.php+4 −3
- typo3/sysext/em/classes/install/class.tx_em_install.php+1 −1
- typo3/sysext/em/classes/parser/class.tx_em_parser_extensionxmlpullparser.php+2 −2
- typo3/sysext/em/classes/parser/class.tx_em_parser_extensionxmlpushparser.php+7 −0
- typo3/sysext/em/classes/parser/class.tx_em_parser_mirrorxmlpullparser.php+2 −2
- typo3/sysext/em/classes/parser/class.tx_em_parser_mirrorxmlpushparser.php+2 −2
- typo3/sysext/em/classes/parser/class.tx_em_parser_xmlparserfactory.php+2 −3
- typo3/sysext/em/classes/reports/class.tx_em_reports_extensionstatus.php+1 −1
- typo3/sysext/em/classes/repository/class.tx_em_repository.php+7 −7
- typo3/sysext/em/classes/repository/class.tx_em_repository_mirrors.php+0 −10
- typo3/sysext/em/classes/repository/class.tx_em_repository_utility.php+8 −7
- typo3/sysext/em/classes/settings/class.tx_em_settings.php+11 −8
- typo3/sysext/em/classes/tools/class.tx_em_tools_xmlhandler.php+0 −1
- typo3/sysext/em/classes/index.php+35 −18
Review log 7
-
Xavier Perseguers commented on patch set 1 09/20/11, 08:10
Fails; No score -
Xavier Perseguers commented on patch set 1 09/20/11, 08:10
Do not submit The list of mirrors is not retrieved anymore -
Xavier Perseguers uploaded patch set 2 09/20/11, 08:10
-
Xavier Perseguers commented on patch set 2 V 0 09/20/11, 08:10
by team member; Looks good to me, approved -
Mr. Jenkins commented on patch set 1 09/20/11, 08:10
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1923/ : SUCCESS -
Mr. Jenkins commented on patch set 2 09/20/11, 08:10
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1924/ : SUCCESS -
Xavier Perseguers merged patch set 2 09/20/11, 08:10