Review TYPO3_7-6 Merged

50980[BUGFIX] Optimize cache handling in ReflectionService

Markus Klein CR +2 V +2 Easy +18 −7 updated 12/16/16, 00:18

Commit message

Method reflection objects are used temporarily to extract information
from methods. This information is eventually stored in the cache.
However the method reflection objects themselves must stay outside the cache
because they cannot be serialized. They also do not provide much value
as the information is stored in the cache anyway.
The only additional info these reflections provided is whether a method
existed or not in the class, which we now also cache as plain array.

Furthermore the information whether cache relevant properties were
updated and the cache needs to be saved again is now reset once it was
written. This ensures that the cache is only written once even the
ReflectionService is used multiple times.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 34

  1. Markus Klein uploaded patch set 1 12/15/16, 23:09

  2. TYPO3com voted on patch set 1 V +1 12/15/16, 23:15 Completed build in 05m 17s on Fri, 16 Dec, 12:15 AM Test Summary: 38338 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-544

  3. Markus Klein voted on patch set 1 CR +2 V +2 12/16/16, 00:18

  4. Gerrit merged patch set 1 12/16/16, 00:18