Review main Merged

50982[TASK] Update file list module access in backend groups and users

Nicole Hummel CR +2 V +2 Normal +116 −0 updated 02/15/17, 07:36

Commit message

As the file list module was renamed, backend groups and users access
lists need adjustments. This patch updates the module name and
removes the non-existing "file" module from those lists.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Nicole Hummel +1
  • Verified V +2
    • Wouter Wolters +2
    • Nicole Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2125

  1. Nicole Hummel uploaded patch set 1 12/15/16, 23:51

  2. TYPO3com voted on patch set 1 V +1 12/15/16, 23:56 Completed build in 05m 12s on Fri, 16 Dec, 12:56 AM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5802

  3. Georg Ringer voted on patch set 1 CR +1 V +1 12/20/16, 07:15

  4. Wouter Wolters voted on patch set 1 CR +1 12/20/16, 08:29

  5. Jörg Bösche voted on patch set 1 CR +1 12/20/16, 14:02

  6. Wouter Wolters commented on patch set 1 CR -1 V -1 12/20/16, 18:55

    FileListInGroupModuleUpdate.php:44

    the be_users can have the file_list too in the field userMods, we should migrate this one too
  7. Wouter Wolters voted on patch set 1 CR 0 V 0 12/30/16, 23:29

  8. Nicole Hummel commented on patch set 1 12/30/16, 23:45

    @Wouter: As I already prepared the backport for 7.6 (without Doctrine) and the be_users access isn't mentioned anywhere (I haven't forund it in forge and I haven't had that problem yet), I would love to handle this update in another patch.
  9. Mathias Schreiber commented on patch set 1 CR -1 12/31/16, 11:10

    If necessary, I can take this over, just give a ping.

    FileListInGroupModuleUpdate.php:46

    This has to be a count query in the first place. Getting the entire resultset does not make sense. Another bonus is that Doctrine forces you to count only one value, resulting in proper SQL.

    FileListInGroupModuleUpdate.php:73

    uid and groupmods is enough here

    FileListInGroupModuleUpdate.php:82

    I'd not reuse the var name $queryBuilder here. We had issues with that during the Doctrine migration

    FileListInGroupModuleUpdate.php:95

    This is more of a general question, because the upgrade wizards are new to me: What happens if an SQL error occurs here? Can we still safely mark the wizard as done?
  10. Nicole Hummel commented on patch set 1 12/31/16, 13:13

    FileListInGroupModuleUpdate.php:46 Reply

    Feel free to change that. I'm not in doctrine API and just took \TYPO3\CMS\Install\Updates\FileListIsStartModuleUpdate as a working update wizard

    FileListInGroupModuleUpdate.php:82 Reply

    see above

    FileListInGroupModuleUpdate.php:95 Reply

    Don't know. There isn't any check for erros yet which might can change the return of the upgrade wizard.
  11. Nicole Hummel uploaded patch set 2 01/01/17, 17:37

  12. TYPO3com voted on patch set 2 V +1 01/01/17, 17:41 Completed build in 03m 40s on Sun, 1 Jan, 06:41 PM Test Summary: 54437 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6131

  13. Nicole Hummel uploaded patch set 3 01/01/17, 17:47

  14. TYPO3com voted on patch set 3 V +1 01/01/17, 17:52 Completed build in 04m 47s on Sun, 1 Jan, 06:51 PM Test Summary: 54437 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6132

  15. Mathias Schreiber commented on patch set 3 CR +1 V +1 01/02/17, 08:07

    perfect patch, thanks
  16. Christian Matthes voted on patch set 3 CR +1 02/13/17, 13:12

  17. Christian Matthes voted on patch set 3 V +1 02/13/17, 13:13

  18. Markus Klein commented on patch set 3 02/13/17, 15:51

    FileListInAccessModuleListUpdate.php:51

    has been
  19. Wouter Wolters commented on patch set 3 02/14/17, 08:48

    FileListInAccessModuleListUpdate.php:76

    string &$customMessage see https://review.typo3.org/#/c/51624/

    FileListInAccessModuleListUpdate.php:80

    &$customMessage
  20. Wouter Wolters uploaded patch set 4 02/14/17, 16:08

  21. Wouter Wolters voted on patch set 4 CR +1 V +1 02/14/17, 16:08

  22. TYPO3com voted on patch set 4 V +1 02/14/17, 16:13 Completed build in 05m 28s on Tue, 14 Feb, 05:13 PM Test Summary: 56277 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8058

  23. Nicole Hummel commented on patch set 4 CR +1 V +1 02/14/17, 16:40

    Thanks for your updates, Wouter!
  24. Wouter Wolters voted on patch set 4 CR +2 V +2 02/15/17, 07:36

  25. Gerrit merged patch set 4 02/15/17, 07:36