Review TYPO3_6-2 Merged

50984[BUGFIX] Optimize cache handling in ReflectionService

Markus Klein CR +2 V +2 Easy +18 −7 updated 12/16/16, 00:46

Commit message

Method reflection objects are used temporarily to extract information
from methods. This information is eventually stored in the cache.
However the method reflection objects themselves must stay outside the cache
because they cannot be serialized. They also do not provide much value
as the information is stored in the cache anyway.
The only additional info these reflections provided is whether a method
existed or not in the class, which we now also cache as plain array.

Furthermore the information whether cache relevant properties were
updated and the cache needs to be saved again is now reset once it was
written. This ensures that the cache is only written once even the
ReflectionService is used multiple times.

Review

  • Code review CR +2
    • Nicole Hummel +2
  • Verified V +2
    • Nicole Hummel +2
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 69

  1. Markus Klein uploaded patch set 1 12/16/16, 00:25

  2. Markus Klein uploaded patch set 2 12/16/16, 00:27

  3. Markus Klein voted on patch set 2 CR +1 12/16/16, 00:27

  4. TYPO3com voted on patch set 1 V -1 12/16/16, 00:29 Completed build in 04m 10s on Fri, 16 Dec, 01:29 AM Test Summary: 318 of 23914 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC6-81

  5. TYPO3com voted on patch set 2 V -1 12/16/16, 00:32 Completed build in 05m 15s on Fri, 16 Dec, 01:32 AM Test Summary: 318 of 23914 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC6-82

  6. Nicole Hummel commented on patch set 3 12/16/16, 00:38

    Published edit on patch set 2.
  7. TYPO3com voted on patch set 3 V +1 12/16/16, 00:41 Completed build in 03m 43s on Fri, 16 Dec, 01:41 AM Test Summary: 30884 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC6-83

  8. Nicole Hummel voted on patch set 3 CR +2 V +2 12/16/16, 00:46

  9. Gerrit merged patch set 3 12/16/16, 00:46