Review main Merged

50995[BUGFIX] Exception in EXT:form due to invalid array lookup

Oliver Hader CR +2 V +2 Normal +112 −50 updated 12/19/16, 16:04

Commit message

Due to the changes of ArrayUtility in issue #77732
EXT:form now has to deal with these problems:

+ core's ArrayUtility uses a slash "/" as delimiter,
  but Extbase's ArrayUtility used a dot "."
+ core's ArrayUtility throws an exception if value is
  not defined, Extbase's ArrayUtility returned null

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Benni Mack +2
    • Ralf Zimmermann +1
  • Verified V +2
    • Christian Kuhn +2
    • Ralf Zimmermann +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1014

  1. Oliver Hader uploaded patch set 1 12/18/16, 13:20

  2. TYPO3com voted on patch set 1 V -1 12/18/16, 13:23 Completed build in 03m 33s on Sun, 18 Dec, 02:23 PM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5839

  3. Oliver Hader uploaded patch set 2 12/19/16, 12:49

  4. Oliver Hader uploaded patch set 3 12/19/16, 12:52

  5. TYPO3com voted on patch set 2 V -1 12/19/16, 12:54 Completed build in 04m 36s on Mon, 19 Dec, 01:54 PM Test Summary: 48 of 54399 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5845

  6. TYPO3com voted on patch set 3 V +1 12/19/16, 12:57 Completed build in 04m 46s on Mon, 19 Dec, 01:57 PM Test Summary: 54399 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5846

  7. Christian Kuhn commented on patch set 3 12/19/16, 12:57

    ArrayAccessUtility.php:34

    I'd prefer to not have a class/method for this wrapper that just catches away an exception. This is hidden magic. I'd rather put the try/catch directly into the consuming classes (that are just a couple) to have that explicitely in your face. Furthermore, we may eventually switch from "throw \RuntimeException" to "throw \typo3\...\InvalidPathException " (or similar) to have an explicit exception catch instead of catching a top level exception.
  8. Oliver Hader uploaded patch set 4 12/19/16, 13:18

  9. Christian Kuhn voted on patch set 4 CR +1 12/19/16, 13:21

  10. TYPO3com voted on patch set 4 V +1 12/19/16, 13:22 Completed build in 04m 18s on Mon, 19 Dec, 02:22 PM Test Summary: 54399 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5847

  11. Ralf Zimmermann voted on patch set 4 CR +1 V +1 12/19/16, 15:52

  12. Benni Mack voted on patch set 4 CR +2 12/19/16, 16:01

  13. Christian Kuhn voted on patch set 4 CR +2 V +2 12/19/16, 16:03

  14. Gerrit merged patch set 4 12/19/16, 16:04