Review main Merged Breaking

50996[!!!][TASK] Always throw exception if a userFunc does not exist

Andreas Kienast CR +2 V +2 Normal +48 −45 updated 06/18/17, 16:13

Commit message

The parameter `$errorMode` is removed from the method
`GeneralUtility::callUserFunction()`. Thus, the checks agains this
variable are removed as well, causing exceptions being always thrown now.

Review

  • Code review CR +2
    • Susi Moog +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1725

  1. Andreas Kienast uploaded patch set 1 12/19/16, 15:31

  2. Andreas Kienast commented on patch set 1 CR -2 12/19/16, 15:32

    This patch is postponed for v9.
  3. TYPO3com voted on patch set 1 V +1 12/19/16, 15:36 Completed build in 04m 28s on Mon, 19 Dec, 04:36 PM Test Summary: 54369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5856

  4. Andreas Kienast uploaded patch set 2 12/19/16, 15:47

  5. Andreas Kienast uploaded patch set 3 12/19/16, 15:49

  6. Andreas Kienast uploaded patch set 4 12/19/16, 15:51

  7. TYPO3com voted on patch set 2 V +1 12/19/16, 15:53 Completed build in 05m 43s on Mon, 19 Dec, 04:53 PM Test Summary: 54369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5857

  8. TYPO3com voted on patch set 3 V +1 12/19/16, 15:53 Completed build in 04m 49s on Mon, 19 Dec, 04:53 PM Test Summary: 54369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5858

  9. TYPO3com voted on patch set 4 V +1 12/19/16, 15:55 Completed build in 04m 04s on Mon, 19 Dec, 04:55 PM Test Summary: 54369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5859

  10. Andreas Kienast uploaded patch set 5 12/19/16, 16:26

  11. TYPO3com voted on patch set 5 V +1 12/19/16, 16:29 Completed build in 03m 42s on Mon, 19 Dec, 05:29 PM Test Summary: 54369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5861

  12. Andreas Kienast voted on patch set 5 CR 0 04/18/17, 07:22

  13. Andreas Kienast uploaded patch set 6 04/19/17, 05:58

  14. TYPO3com voted on patch set 6 V +1 04/19/17, 06:07 Completed build in 09m 25s on Wed, 19 Apr, 08:07 AM Test Summary: 56174 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10695

  15. Benni Mack commented on patch set 6 CR -2 04/19/17, 11:58

    Please wait with this change until ExtDirect dispatcher and AjaxRequestHandler is gone
  16. Benni Mack voted on patch set 6 CR 0 06/14/17, 15:46

  17. Benni Mack uploaded patch set 7 06/14/17, 15:57

  18. TYPO3com voted on patch set 7 V +1 06/14/17, 16:09 Completed build in 12m 30s on Wed, 14 Jun, 06:09 PM Test Summary: 56484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12579

  19. Georg Ringer commented on patch set 7 06/14/17, 16:13

    Breaking-74533-ThrowExceptionIfUserFunctionDoesNotExist.rst:13

    The removal of the errormode parameter should be mentioned IMO as well.
  20. Andreas Kienast uploaded patch set 8 06/17/17, 12:00

  21. TYPO3com voted on patch set 8 V +1 06/17/17, 12:09 Completed build in 09m 28s on Sat, 17 Jun, 02:09 PM Test Summary: 56484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12647

  22. Benni Mack voted on patch set 8 CR +1 V +1 06/17/17, 19:05

  23. Oliver Klee voted on patch set 8 CR +1 06/18/17, 13:33

  24. Susi Moog voted on patch set 8 CR +2 V +2 06/18/17, 16:13

  25. Gerrit merged patch set 8 06/18/17, 16:13