Review main Merged

5101[TASK] Missing report for deprecated setting magic_quotes_gpc

Xavier Perseguers CR +2 V +2 Normal +48 −3 updated 06/03/13, 20:49

Commit message

Since PHP 5.3, PHP INI setting magic_quotes_gpc is deprecated but still
defaults to "On". A report should be added to raise awareness of the
administrators.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Stefan Neufeind +1
    • Jigal van Hemert +1
  • Verified V +2
    • Xavier Perseguers +2
    • Jigal van Hemert +1

Issues 1

Files 3

Review log 8

  1. Stefan Neufeind commented on patch set 2 09/20/11, 11:34

    Looks good to me, but someone else must approve
  2. Xavier Perseguers commented on patch set 2 V 0 09/20/11, 11:34

    by team member; Looks good to me, approved
  3. Xavier Perseguers uploaded patch set 2 09/20/11, 11:34

  4. Jigal van Hemert commented on patch set 1 09/20/11, 11:34

    (1 inline comment)

    class.t3lib_utility_phpoptions.php:51

    The manual ( http://www.php.net/manual/en/info.configuration.php#ini.magic-quotes-gpc ) states that it is deprecated as of PHP 5.3.0, but it doesn't say that it will be removed in 5.4.
  5. Jigal van Hemert commented on patch set 2 09/20/11, 11:34

    Verified; Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 09/20/11, 11:34

  7. Mr. Jenkins commented on patch set 2 09/20/11, 11:34

  8. Xavier Perseguers merged patch set 2 09/20/11, 11:34