51013[TASK] Add getter for cacheTags in TypoScriptFrontendController
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1922
-
Georg Ringer uploaded patch set 1 12/21/16, 11:44
-
Mathias Brodala voted on patch set 1 CR +1 12/21/16, 11:47
-
TYPO3com voted on patch set 1 V +1 12/21/16, 11:48 Completed build in 03m 48s on Wed, 21 Dec, 12:48 PM Test Summary: 54399 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5909
-
David Greiner commented on patch set 1 CR +1 01/13/17, 13:13
Looks good for me and works as expected. But why introducing a method that is never used? -
Mathias Brodala commented on patch set 1 01/13/17, 13:16
> Looks good for me and works as expected. But why introducing a > method that is never used? It's not called by TYPO3 itself, yes but there are use cases for this, see Forge. -
David Greiner commented on patch set 1 01/13/17, 13:19
Oh, i see. Ok! -
Benni Mack voted on patch set 1 CR +2 V +1 01/18/17, 10:22
-
Benni Mack updated the commit message in patch set 2 01/18/17, 11:11
-
Benni Mack voted on patch set 2 CR +1 V +1 01/18/17, 11:11
-
TYPO3com voted on patch set 2 V +1 01/18/17, 11:17 Completed build in 05m 43s on Wed, 18 Jan, 12:17 PM Test Summary: 54981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6762
-
Markus Klein commented on patch set 2 01/18/17, 12:01
TypoScriptFrontendController.php:3225return type missing. I would suggest to add one, agreed? -
Josef Glatz uploaded patch set 3 02/08/17, 21:54
-
TYPO3com voted on patch set 3 V +1 02/08/17, 22:00 Completed build in 05m 24s on Wed, 8 Feb, 11:00 PM Test Summary: 56225 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7808
-
Tymoteusz Motylewski voted on patch set 3 CR +1 V +1 02/09/17, 21:39
-
Nicole Hummel commented on patch set 3 02/09/17, 23:49
Just a note: there is a way to fetch the tags without having to add new public api. You can simply use 'insertPageIncache' hook and get all tags from database with hash \TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController::$newHash I'm against having another public function in TSFE. -
Frank Nägler voted on patch set 3 CR +1 V +1 03/08/17, 23:25
-
Benni Mack commented on patch set 3 CR -1 03/09/17, 06:41
I think we should go with Nicole's approach for now. I plan to thin out TSFE even more in v9 with all cache-related parts moved to a separate class (PageCache) -
Frans Saris commented on patch set 3 03/09/17, 07:21
But that doesn't help with getting the values during runtime when not persistent yet current? -
Frank Nägler commented on patch set 3 03/09/17, 08:16
I agree with Frans, the problem can not be solved without the patch. And for now this is a good solution. I am fine to mark the method as internal or deprecated. But we should add the method for the time being. -
Nicole Hummel commented on patch set 3 CR -1 03/09/17, 10:05
I just had a quick look but right before the hook $this->setPageCacheContent() is called which sets writes the page content with all available tags into the cache. Can you tell me which case isn't covered by that? -
Nicole Hummel commented on patch set 3 03/10/17, 00:20
BTW: that getter doesn't ensure a proper state of tags. As the last tags are added in setPageCacheContent() any call before would result in a wrong tag state. I would recommend to extend the insertPageIncache hook and provide the tags as an additional information. Furthermore we might introduce some findTagsByIdentifier to the cache API. -
Georg Ringer abandoned the change 07/04/17, 18:07