Review main Merged

51017[BUGFIX] Check in TcaMigration if the type is set

Georg Ringer CR +2 V +2 Normal +86 −3 updated 01/04/17, 11:35

Commit message

The type field is essential for TCA and must be checked if available.

Review

  • Code review CR +2
    • Jan Helke +2
    • Christian Kuhn +1
  • Verified V +2
    • Jan Helke +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 811

  1. Georg Ringer uploaded patch set 1 12/22/16, 08:31

  2. TYPO3com voted on patch set 1 V +1 12/22/16, 08:36 Completed build in 04m 51s on Thu, 22 Dec, 09:36 AM Test Summary: 54405 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5918

  3. Morton Jonuschat commented on patch set 1 CR -1 12/31/16, 16:58

    TcaMigration.php:82

    This is not a sanitizing (cleaning of data), this is a validation of data, the method should be renamed to something that describes what the method does. Maybe validateTcaTypeIsDefined() or just validateTcaTypes()
  4. Georg Ringer uploaded patch set 2 01/02/17, 07:50

  5. TYPO3com voted on patch set 2 V +1 01/02/17, 07:55 Completed build in 05m 23s on Mon, 2 Jan, 08:55 AM Test Summary: 54443 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6143

  6. Morton Jonuschat voted on patch set 2 CR +1 V +1 01/02/17, 19:33

  7. Christian Kuhn uploaded patch set 3 01/04/17, 11:27

  8. Christian Kuhn commented on patch set 3 CR +1 V +1 01/04/17, 11:29

    rebased. I left out the 7.6 backport: It may happen that some extension somewhere missed a type in some field and maybe that somehow worked. Throwing a hard exception in bootstrap would then mean that a project stops working with a patch level upgrade, we shouldn't trigger that.
  9. TYPO3com voted on patch set 3 V +1 01/04/17, 11:31 Completed build in 04m 09s on Wed, 4 Jan, 12:31 PM Test Summary: 54907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6202

  10. Jan Helke voted on patch set 3 CR +2 V +2 01/04/17, 11:35

  11. Gerrit merged patch set 3 01/04/17, 11:35