51020Revert "[BUGFIX] Add missing getTemplatePathAndFilename() in TemplatePaths"
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 3
Review log 1315
-
Claus Due uploaded patch set 1 12/22/16, 12:27
-
TYPO3com voted on patch set 1 V +1 12/22/16, 12:31 Completed build in 04m 07s on Thu, 22 Dec, 01:31 PM Test Summary: 54399 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5926
-
Andreas Kienast commented on patch set 1 CR -1 12/22/16, 14:58
Please add the ticket that gets reverted with this patch as "Related: #XXXXX" -
Wouter Wolters updated the commit message in patch set 2 12/22/16, 15:27
-
TYPO3com voted on patch set 2 V +1 12/22/16, 15:33 Completed build in 06m 22s on Thu, 22 Dec, 04:33 PM Test Summary: 54399 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5939
-
Markus Klein commented on patch set 2 CR -1 V -1 12/22/16, 15:52
nope and nope! -
Claus Due commented on patch set 2 12/22/16, 15:54
Would you mind adding a reason for the two -1s, Markus? -
Markus Klein commented on patch set 2 12/22/16, 15:55
1.) the bugreport ticekt does not declare a relation to the "offending" ticket 2.) no comment in the original review why this shall be reverted 3.) do not revert a change that fixes something, but provide a patch that changes the working code to another working code 4.) we do a lot of type clarification here, you only seem to worry about one aspect of the change. IMO no reason to revert all of it. -
Wouter Wolters voted on patch set 2 CR +1 V +1 12/22/16, 15:57
-
Wouter Wolters commented on patch set 2 12/22/16, 15:57
New fix in https://review.typo3.org/#/c/51021/ -
Claus Due commented on patch set 2 12/22/16, 15:57
Okay, so first of all: the first commit combined MANY fixes into one, which is not desired. Next, it "solves" the problem in the wrong way. Third, I've created a followup for this which solves it the right way. Please don't ever give me a "nope and nope" response again. It's super disrespectful! -
Markus Klein commented on patch set 2 12/22/16, 16:00
I needed to take the full brake, before you merge that. I needed time to type. I find it super disrespectful to revert a patch without even writing a single line to the former author/reviewers why that is done. Your new patch introduces unclean code again (objectmanager again declared dynamically) Please simply create a task change that transforms the wrong code into better code. Thanks -
Claus Due commented on patch set 2 12/22/16, 16:03
Did you read my first point about the commit mixing up multiple fixes? Anywho, now you know the full situation. Treat other contributors the same way you'd like them to treat you. Right? -
Markus Klein commented on patch set 2 CR 0 V 0 12/22/16, 16:59
After discussion with Claus. I stick to my opinion that a revert should only be considered if code is seriously broken, which seems not the case. Yet he has the freedom to propose what he likes and I'm not standing in the way. Please keep in mind though that reverts have to follow our policy and therefore please double check if all reference, notes, states and so on are set as necessary. Thanks. -
Claus Due abandoned the change 05/11/17, 12:11