Review main Merged

51040[BUGFIX] Fix sorting in language list

Markus Sommer CR +2 V +2 Easy +16 −14 updated 01/05/17, 23:41

Commit message

* Add sorting field for A/D
* disable senseless sorting of actions

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Markus Sommer +1
  • Verified V +2
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Markus Sommer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1113

  1. Markus Sommer uploaded patch set 1 12/23/16, 13:46

  2. TYPO3com voted on patch set 1 V +1 12/23/16, 13:50 Completed build in 03m 44s on Fri, 23 Dec, 02:50 PM Test Summary: 54399 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5965

  3. Michael Oehlhof voted on patch set 1 CR +1 V +1 12/23/16, 14:05

  4. Georg Ringer commented on patch set 1 12/26/16, 08:43

    ListLanguages.html:48

    can we make that translateable as well?
  5. Mona Muzaffar commented on patch set 1 01/05/17, 14:48

    could you please give me some more details about the bug? I don't really get which fields you mean and which behavior you are trying to achieve.
  6. Michael Oehlhof commented on patch set 1 01/05/17, 15:08

    Choose "Language" from the "Admin-Tools" in the BE. You can sort the table when clicking on the labels in the table header. Sorting is possible for the Language, Locale and "Last update" columns. With this patch also sorting for "A/D" is possible.
  7. Daniel Goerz uploaded patch set 2 01/05/17, 15:57

  8. Daniel Goerz commented on patch set 1 01/05/17, 15:57

    Labels were already there

    ListLanguages.html:48 Reply

    Done
  9. Daniel Goerz voted on patch set 2 CR +1 V +1 01/05/17, 15:58

  10. TYPO3com voted on patch set 2 V +1 01/05/17, 16:02 Completed build in 05m 12s on Thu, 5 Jan, 05:02 PM Test Summary: 54907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6233

  11. Markus Sommer voted on patch set 2 CR +1 V +1 01/05/17, 19:55

  12. Christian Kuhn voted on patch set 2 CR +2 V +2 01/05/17, 23:41

  13. Gerrit merged patch set 2 01/05/17, 23:41