Review main Merged

51043[BUGFIX] EXT:info_pagetsconfig Optimized view on page 0

Michael Oehlhof CR +2 V +2 Easy +31 −18 updated 02/26/17, 17:47

Commit message

If there are no pages containing Page TSconfig settings in the page
configuration an info FlashMessage is shown instead of an empty table.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Josef Glatz +1
  • Verified V +2
    • Christian Kuhn +2
    • Josef Glatz +1
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1114

  1. Michael Oehlhof uploaded patch set 1 12/25/16, 22:00

  2. TYPO3com voted on patch set 1 V +1 12/25/16, 22:03 Completed build in 03m 18s on Sun, 25 Dec, 11:03 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5981

  3. Georg Ringer commented on patch set 1 CR -1 12/26/16, 08:41

  4. Michael Oehlhof uploaded patch set 2 12/26/16, 10:58

  5. TYPO3com voted on patch set 2 V +1 12/26/16, 11:02 Completed build in 04m 07s on Mon, 26 Dec, 12:02 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5985

  6. Gianluigi Martino voted on patch set 2 V +1 12/28/16, 09:00

  7. Riccardo De Contardi voted on patch set 2 V +1 02/08/17, 08:45

  8. Josef Glatz commented on patch set 2 CR -1 V +1 02/13/17, 23:02

    The callout looks nice. But the info messages is a little bit confusing, because, if I click on a page in the pagetree - the default PageTSConfig is shown. What about adding the word "custom" > "There are no pages containing custom PageTSconfig settings in the page configuration."?
  9. Josef Glatz uploaded patch set 3 02/26/17, 17:31

  10. Josef Glatz voted on patch set 3 CR +1 V +1 02/26/17, 17:32

  11. Riccardo De Contardi voted on patch set 3 V +1 02/26/17, 17:40

  12. TYPO3com voted on patch set 3 V +1 02/26/17, 17:42 Completed build in 10m 43s on Sun, 26 Feb, 06:42 PM Test Summary: 56406 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8617

  13. Christian Kuhn voted on patch set 3 CR +2 V +2 02/26/17, 17:47

  14. Gerrit merged patch set 3 02/26/17, 17:47