Review main Merged

51044[BUGFIX] System > Access module now starting in selected page of page tree

Michael Oehlhof CR +2 V +2 Easy +1 −0 updated 06/05/17, 16:44

Commit message

Review

  • Code review CR +2
    • Frank Nägler +2
    • Gianluigi Martino +1
  • Verified V +2
    • Frank Nägler +2
    • Riccardo De Contardi +1
    • Gianluigi Martino +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 910

  1. Michael Oehlhof uploaded patch set 1 12/25/16, 23:36

  2. TYPO3com voted on patch set 1 V +1 12/25/16, 23:39 Completed build in 03m 27s on Mon, 26 Dec, 12:39 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5982

  3. Andreas Kienast commented on patch set 1 12/26/16, 20:57

    I may raise two questions (didn't cherry-pick the patch yet): * Can we apply this to 7.6 as well? * Do other "system" still work?
  4. Michael Oehlhof commented on patch set 1 12/27/16, 07:49

    I think it could also applied to 7.6 I have seen no impact for other system modules.
  5. Gianluigi Martino voted on patch set 1 CR +1 V +1 12/28/16, 08:51

  6. Riccardo De Contardi voted on patch set 1 V +1 12/29/16, 10:04

  7. Benni Mack commented on patch set 1 01/01/17, 20:02

    there are a lot of places where "web" is set throughout the code. I think we'd need to adapt that. However, I think we should treat the "page" and "file" IDs different. Let me think about that for a bit...
  8. Elmar Hinz commented on patch set 1 05/12/17, 11:39

    Conceptional proposals how to proceed? @benni
  9. Frank Nägler voted on patch set 1 CR +2 V +2 06/05/17, 16:44

  10. Gerrit merged patch set 1 06/05/17, 16:44