Review main Merged

51045[TASK] EXT:viewpage: Added page title as headline

Michael Oehlhof CR +2 V +2 Easy +20 −0 updated 12/31/16, 16:44

Commit message

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Gianluigi Martino +1
  • Verified V +2
    • Morton Jonuschat +2
    • Gianluigi Martino +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 68

  1. Michael Oehlhof uploaded patch set 1 12/26/16, 00:46

  2. TYPO3com voted on patch set 1 V +1 12/26/16, 00:50 Completed build in 04m 49s on Mon, 26 Dec, 01:50 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5983

  3. Georg Ringer commented on patch set 1 CR -1 12/26/16, 08:39

    ViewModuleController.php:311

    not an array

    ViewModuleController.php:316

    please don't call it $tce as tcemain is long time ago and just use BackendUtility getRecord instead
  4. Michael Oehlhof uploaded patch set 2 12/26/16, 10:47

  5. TYPO3com voted on patch set 2 V +1 12/26/16, 10:51 Completed build in 04m 01s on Mon, 26 Dec, 11:51 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5984

  6. Gianluigi Martino voted on patch set 2 CR +1 V +1 12/28/16, 08:55

  7. Morton Jonuschat voted on patch set 2 CR +2 V +2 12/31/16, 16:44

  8. Gerrit merged patch set 2 12/31/16, 16:44