Review main Merged

51046[BUGFIX] EXT:tstemplate: Removed double escaping of page name

Michael Oehlhof CR +2 V +2 Easy +1 −1 updated 01/07/17, 20:17

Commit message

Because the escaping takes place when the PageZero template is rendered
by the view, there is no need to escape it in the controller.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Daniel Goerz +1
  • Verified V +2
    • Andreas Kienast +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1520

  1. Michael Oehlhof uploaded patch set 1 12/26/16, 22:04

  2. TYPO3com voted on patch set 1 V +1 12/26/16, 22:08 Completed build in 04m 05s on Mon, 26 Dec, 11:08 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5987

  3. Gianluigi Martino voted on patch set 1 CR +1 V +1 12/28/16, 08:57

  4. Morton Jonuschat updated the commit message in patch set 2 12/31/16, 16:50

  5. Morton Jonuschat voted on patch set 2 CR +1 V +1 12/31/16, 16:50

  6. TYPO3com voted on patch set 2 V +1 12/31/16, 16:54 Completed build in 04m 12s on Sat, 31 Dec, 05:54 PM Test Summary: 54435 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6115

  7. Helmut Hummel commented on patch set 2 CR -1 01/03/17, 08:50

    can you add a remark in the commit message where the title is going to be correctly escaped then? thanks
  8. Michael Oehlhof updated the commit message in patch set 3 01/03/17, 09:58

  9. TYPO3com voted on patch set 3 V +1 01/03/17, 10:03 Completed build in 04m 26s on Tue, 3 Jan, 11:03 AM Test Summary: 54437 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6169

  10. Helmut Hummel commented on patch set 3 01/03/17, 10:41

    oh, I'm sorry. You seem to have misunderstood my comment. I didn't want to have a bug description in the commit message (that belongs to the bugtracker), but an explanation where the title is then escaped, when the htmlspcialchars is removed in the controller.
  11. Michael Oehlhof updated the commit message in patch set 4 01/03/17, 13:30

  12. TYPO3com voted on patch set 4 V +1 01/03/17, 13:34 Completed build in 03m 50s on Tue, 3 Jan, 02:34 PM Test Summary: 54437 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6183

  13. Helmut Hummel commented on patch set 4 01/03/17, 14:44

    thanks!
  14. Daniel Goerz voted on patch set 4 CR +1 V +1 01/07/17, 19:53

  15. Andreas Kienast updated the commit message in patch set 5 01/07/17, 20:10

  16. Andreas Kienast voted on patch set 5 CR +1 01/07/17, 20:11

  17. Daniel Goerz voted on patch set 5 CR +1 V +1 01/07/17, 20:12

  18. TYPO3com voted on patch set 5 V +1 01/07/17, 20:15 Completed build in 04m 28s on Sat, 7 Jan, 09:15 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6277

  19. Andreas Kienast voted on patch set 5 CR +2 V +2 01/07/17, 20:17

  20. Gerrit merged patch set 5 01/07/17, 20:17