Review main Merged

51047[TASK] Add CSH button to CreateFolder module

Michael Oehlhof CR +2 V +2 Easy +12 −0 updated 12/30/16, 22:36

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Gianluigi Martino +1
  • Verified V +2
    • Benni Mack +2
    • Gianluigi Martino +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 912

  1. Michael Oehlhof uploaded patch set 1 12/26/16, 23:16

  2. TYPO3com voted on patch set 1 V +1 12/26/16, 23:20 Completed build in 04m 15s on Tue, 27 Dec, 12:20 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5988

  3. Frans Saris commented on patch set 1 12/27/16, 08:24

    "inside the folder" without "of"
  4. Michael Oehlhof commented on patch set 2 12/27/16, 10:00

    Published edit on patch set 1.
  5. TYPO3com voted on patch set 2 V +1 12/27/16, 10:05 Completed build in 04m 49s on Tue, 27 Dec, 11:05 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5989

  6. Gianluigi Martino commented on patch set 2 12/28/16, 08:48

    Should not be "Create new files and folders..." multiple files and multiple folders (sorry if my english is wrong)
  7. Benni Mack commented on patch set 3 12/30/16, 13:32

    Published edit on patch set 2.
  8. Benni Mack voted on patch set 3 CR +1 V +1 12/30/16, 13:33

  9. TYPO3com voted on patch set 3 V +1 12/30/16, 13:38 Completed build in 06m 10s on Fri, 30 Dec, 02:38 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6070

  10. Gianluigi Martino voted on patch set 3 CR +1 V +1 12/30/16, 13:54

  11. Benni Mack voted on patch set 3 CR +2 V +2 12/30/16, 22:36

  12. Gerrit merged patch set 3 12/30/16, 22:36