51048[BUGFIX] Prevent fatal error in TemplatePaths without TS
Commit message
Review
-
Code review CR +2
- Morton Jonuschat +2
- Markus Klein +1
- Wouter Wolters +1
- Benni Mack +1
-
Verified V +2
- Markus Klein +2
- Mona Muzaffar +1
- Morton Jonuschat +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1618
-
Claus Due uploaded patch set 1 12/27/16, 13:34
-
Claus Due commented on patch set 1 12/27/16, 13:35
Tagged with Releases including 8.5 since in the event we do a bugfix release (like we did 8.4.1) I would very much appreciate if this could be included. -
TYPO3com voted on patch set 1 V +1 12/27/16, 13:39 Completed build in 04m 23s on Tue, 27 Dec, 02:39 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5992
-
Benni Mack updated the commit message in patch set 2 12/29/16, 08:26
-
Benni Mack commented on patch set 2 CR +1 12/29/16, 08:27
Hey Claus, no 8.5.1 planned. -
Wouter Wolters voted on patch set 2 CR +1 12/29/16, 08:28
-
TYPO3com voted on patch set 2 V +1 12/29/16, 08:31 Completed build in 04m 11s on Thu, 29 Dec, 09:31 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6028
-
Morton Jonuschat voted on patch set 2 CR +2 V +1 12/31/16, 16:55
-
Benni Mack commented on patch set 2 01/03/17, 06:25
Hey Claus, shouldn't we fix it in the Extbase Configuration Manager to make sure that there is always an array returned? -
Claus Due commented on patch set 2 01/03/17, 09:26
My thinking was, there are cases where you might still want the ConfigurationManager to return NULL. My personal opinion though is it would be nicer that way - but that would then be a breaking change instead of a bug fix, and the cause is still just an edge case. -
Mona Muzaffar commented on patch set 2 01/04/17, 11:58
Hello Claus, I don't really get how i can reproduce this error, to verify your patch. Could you help me out? -
Claus Due commented on patch set 2 01/04/17, 12:11
To reproduce this one, render a template file (using a view) from within for example an ext_localconf.php file. Like I said, it's definitely an edge case because the rendering has to happen *that* early in the runtime to cause the error ;) -
Markus Klein voted on patch set 2 CR +1 V +1 01/04/17, 13:30
-
Claus Due commented on patch set 2 01/04/17, 19:54
8.5.1 was released without this patch, causing Flux to require an override of FrontendConfigurationManager. Sadpanda.gif. Hope this can get some +2 love so if 8.5.2 happens, Flux can require that and drop this override again. -
Mona Muzaffar voted on patch set 2 V -1 01/05/17, 13:46
-
Mona Muzaffar voted on patch set 2 V +1 01/05/17, 13:46
-
Markus Klein voted on patch set 2 V +2 01/05/17, 19:32
-
Gerrit merged patch set 2 01/05/17, 19:32