51049[FEATURE] Page module: Show notice "Content is also shown on:"
Commit message
Review
-
Code review CR +2
- Frans Saris +2
- Tymoteusz Motylewski +1
-
Verified V +2
- Frans Saris +2
- Tymoteusz Motylewski +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1621
-
Michael Oehlhof uploaded patch set 1 12/27/16, 15:41
-
TYPO3com voted on patch set 1 V +1 12/27/16, 15:45 Completed build in 04m 19s on Tue, 27 Dec, 04:45 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5993
-
Georg Ringer commented on patch set 1 CR -1 12/27/16, 18:27
PageLayoutController.php:671why removeAll? why should deleted pages be shown?PageLayoutController.php:680use $links as array and do an implode in the endPageLayoutController.php:685hsc() missingPageLayoutController.php:692can't be do a call out and render all links in the template if fluid is already used? -
Michael Oehlhof commented on patch set 1 12/27/16, 20:39
PageLayoutController.php:669ReplyOKPageLayoutController.php:671ReplyThe deleted restriction is added after the removeAll. Hidden pages should be shown.PageLayoutController.php:680ReplyOKPageLayoutController.php:685ReplyWhere does hsc() is missing? The $title has hsc().PageLayoutController.php:692ReplyI'm using the existent fluid variables, don't want to enhance the template. -
Michael Oehlhof uploaded patch set 2 12/27/16, 20:50
-
TYPO3com voted on patch set 2 V -1 12/27/16, 20:54 Completed build in 04m 14s on Tue, 27 Dec, 09:54 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5996
-
Michael Oehlhof uploaded patch set 3 12/28/16, 08:22
-
Georg Ringer commented on patch set 2 12/28/16, 08:23
PageLayoutController.php:688CGL is not ok there I guess, use "./typo3/sysext/core/Build/Scripts/cglFixMyCommit.sh" to fix it locallayPageLayoutController.php:703linkToPid must be wrapped in hsc() -
TYPO3com voted on patch set 3 V +1 12/28/16, 08:26 Completed build in 03m 53s on Wed, 28 Dec, 09:26 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5999
-
Michael Oehlhof uploaded patch set 4 12/28/16, 08:36
-
TYPO3com voted on patch set 4 V +1 12/28/16, 08:40 Completed build in 03m 54s on Wed, 28 Dec, 09:40 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6000
-
Tymoteusz Motylewski commented on patch set 4 CR -1 02/07/17, 09:07
PageLayoutController.php:687description of the method is missing.PageLayoutController.php:688the name of this method should be more speaking. -
Michael Oehlhof uploaded patch set 5 02/07/17, 12:11
-
TYPO3com voted on patch set 5 V +1 02/07/17, 12:18 Completed build in 06m 59s on Tue, 7 Feb, 01:18 PM Test Summary: 56139 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7673
-
Tymoteusz Motylewski commented on patch set 5 V +1 02/07/17, 12:35
locallang_layout.xlf:265Content from this patch is also shown on: %s -
Michael Oehlhof commented on patch set 5 02/07/17, 12:40
locallang_layout.xlf:265Reply"Content from this patch" ????? You see this message when you are displaying the content of a page in BE. So "This content" means the content you are just seeing. -
Frans Saris voted on patch set 5 CR +1 V +1 02/07/17, 12:42
-
Tymoteusz Motylewski commented on patch set 5 02/07/17, 12:43
locallang_layout.xlf:265Replysorry, I wanted to say "Content from this page..." ;) -
Tymoteusz Motylewski commented on patch set 5 CR +1 02/07/17, 12:46
locallang_layout.xlf:265ReplyI will not argue about it :) The "This content is also shown on:" was not verbose enough for me, but maybe it's just me ;) -
Frans Saris voted on patch set 5 CR +2 V +2 02/07/17, 19:20
-
Gerrit merged patch set 5 02/07/17, 19:20
PageLayoutController.php:669