Review main Merged

51049[FEATURE] Page module: Show notice "Content is also shown on:"

Michael Oehlhof CR +2 V +2 Normal +66 −0 updated 02/07/17, 19:20

Commit message

If a page is selected in page module which content is also shown on
other pages, now a notice is shown with the titles and pid of these pages.

Review

  • Code review CR +2
    • Frans Saris +2
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Frans Saris +2
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1621

  1. Michael Oehlhof uploaded patch set 1 12/27/16, 15:41

  2. TYPO3com voted on patch set 1 V +1 12/27/16, 15:45 Completed build in 04m 19s on Tue, 27 Dec, 04:45 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5993

  3. Georg Ringer commented on patch set 1 CR -1 12/27/16, 18:27

    PageLayoutController.php:669

    please create a new method which makes it easier to refactor the class if ever done

    PageLayoutController.php:671

    why removeAll? why should deleted pages be shown?

    PageLayoutController.php:680

    use $links as array and do an implode in the end

    PageLayoutController.php:685

    hsc() missing

    PageLayoutController.php:692

    can't be do a call out and render all links in the template if fluid is already used?
  4. Michael Oehlhof commented on patch set 1 12/27/16, 20:39

    PageLayoutController.php:669 Reply

    OK

    PageLayoutController.php:671 Reply

    The deleted restriction is added after the removeAll. Hidden pages should be shown.

    PageLayoutController.php:680 Reply

    OK

    PageLayoutController.php:685 Reply

    Where does hsc() is missing? The $title has hsc().

    PageLayoutController.php:692 Reply

    I'm using the existent fluid variables, don't want to enhance the template.
  5. Michael Oehlhof uploaded patch set 2 12/27/16, 20:50

  6. TYPO3com voted on patch set 2 V -1 12/27/16, 20:54 Completed build in 04m 14s on Tue, 27 Dec, 09:54 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5996

  7. Michael Oehlhof uploaded patch set 3 12/28/16, 08:22

  8. Georg Ringer commented on patch set 2 12/28/16, 08:23

    PageLayoutController.php:688

    CGL is not ok there I guess, use "./typo3/sysext/core/Build/Scripts/cglFixMyCommit.sh" to fix it locallay

    PageLayoutController.php:703

    linkToPid must be wrapped in hsc()
  9. TYPO3com voted on patch set 3 V +1 12/28/16, 08:26 Completed build in 03m 53s on Wed, 28 Dec, 09:26 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5999

  10. Michael Oehlhof uploaded patch set 4 12/28/16, 08:36

  11. TYPO3com voted on patch set 4 V +1 12/28/16, 08:40 Completed build in 03m 54s on Wed, 28 Dec, 09:40 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6000

  12. Tymoteusz Motylewski commented on patch set 4 CR -1 02/07/17, 09:07

    PageLayoutController.php:687

    description of the method is missing.

    PageLayoutController.php:688

    the name of this method should be more speaking.
  13. Michael Oehlhof uploaded patch set 5 02/07/17, 12:11

  14. TYPO3com voted on patch set 5 V +1 02/07/17, 12:18 Completed build in 06m 59s on Tue, 7 Feb, 01:18 PM Test Summary: 56139 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7673

  15. Tymoteusz Motylewski commented on patch set 5 V +1 02/07/17, 12:35

    locallang_layout.xlf:265

    Content from this patch is also shown on: %s
  16. Michael Oehlhof commented on patch set 5 02/07/17, 12:40

    locallang_layout.xlf:265 Reply

    "Content from this patch" ????? You see this message when you are displaying the content of a page in BE. So "This content" means the content you are just seeing.
  17. Frans Saris voted on patch set 5 CR +1 V +1 02/07/17, 12:42

  18. Tymoteusz Motylewski commented on patch set 5 02/07/17, 12:43

    locallang_layout.xlf:265 Reply

    sorry, I wanted to say "Content from this page..." ;)
  19. Tymoteusz Motylewski commented on patch set 5 CR +1 02/07/17, 12:46

    locallang_layout.xlf:265 Reply

    I will not argue about it :) The "This content is also shown on:" was not verbose enough for me, but maybe it's just me ;)
  20. Frans Saris voted on patch set 5 CR +2 V +2 02/07/17, 19:20

  21. Gerrit merged patch set 5 02/07/17, 19:20