Review main Merged

51052[TASK] Filelist: Info dialog shows image dimensions

Michael Oehlhof CR +2 V +2 Easy +16 −1 updated 01/11/17, 21:07

Commit message

The file info modal now contains the width and height of images

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Frans Saris +1
  • Verified V +2
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Frans Saris +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2631

Show 56 earlier messages
  1. Michael Oehlhof uploaded patch set 1 12/28/16, 08:06

  2. TYPO3com voted on patch set 1 V +1 12/28/16, 08:11 Completed build in 04m 59s on Wed, 28 Dec, 09:11 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5998

  3. Gianluigi Martino commented on patch set 1 CR +1 V +1 12/28/16, 08:45

    Nice one
  4. Andreas Kienast commented on patch set 1 12/29/16, 09:59

    ElementInformationController.php:332

    strpos($mimeType, 'image') === 0
  5. Riccardo De Contardi voted on patch set 1 V +1 12/29/16, 10:00

  6. Michael Oehlhof commented on patch set 2 12/29/16, 11:07

    Published edit on patch set 1.
  1. TYPO3com voted on patch set 2 V +1 12/29/16, 11:12 Completed build in 05m 18s on Thu, 29 Dec, 12:12 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6032

  2. Riccardo De Contardi voted on patch set 2 V +1 12/29/16, 11:18

  3. Gianluigi Martino voted on patch set 2 CR +1 V +1 12/30/16, 13:54

  4. Markus Klein commented on patch set 2 12/30/16, 23:59

    Feature... IMHO that is even a bugfix, because this information is actually really really useful. Proposal: Make it a TASK and target also for 7.6
  5. Michael Oehlhof commented on patch set 2 12/31/16, 11:21

    Than we have also drop the feature ReST file, because it is not Breaking, Deprecation, Feature, Important.
  6. Wouter Wolters commented on patch set 2 12/31/16, 13:06

    I agree with a backport to 7.6
  7. Markus Klein commented on patch set 3 01/04/17, 15:05

    Published edit on patch set 2.
  8. Markus Klein commented on patch set 3 01/04/17, 15:09

    ElementInformationController.php:331

    I would suggest to use: if ($this->fileObject->getType() === AbstractFile::FILETYPE_IMAGE)

    ElementInformationController.php:335

    we need to add a language condition as well

    ElementInformationController.php:364

    $name === 'width' || $name === 'height' no need to create an extra array for static strings and run a loop over it.
  9. TYPO3com voted on patch set 3 V +1 01/04/17, 15:10 Completed build in 04m 15s on Wed, 4 Jan, 04:09 PM Test Summary: 54907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6216

  10. Riccardo De Contardi commented on patch set 3 V +1 01/04/17, 15:15

    tested with latest master
  11. Michael Oehlhof commented on patch set 3 01/05/17, 08:42

    ElementInformationController.php:364 Reply

    Should I also change this for 'creation_date' and 'modification_date' in line 367
  12. Markus Klein commented on patch set 3 01/05/17, 09:10

    Good point, yes please.
  13. Frans Saris commented on patch set 3 CR -1 01/05/17, 15:09

    will push an update

    ElementInformationController.php:335 Reply

    No need to fetch the metadataRecord. It is already present in $this->fileObject

    ElementInformationController.php:364 Reply

    } elseif ($name === 'width') { $rowValue = $this->fileObject->getProperty('width'); } elseif ($name === 'height') { $rowValue = $this->fileObject->getProperty('height'); }
  14. Frans Saris uploaded patch set 4 01/05/17, 15:15

  15. Frans Saris voted on patch set 4 CR +1 V +1 01/05/17, 15:16

  16. TYPO3com voted on patch set 4 V +1 01/05/17, 15:20 Completed build in 04m 06s on Thu, 5 Jan, 04:19 PM Test Summary: 54907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6231

  17. Michael Oehlhof commented on patch set 4 01/05/17, 15:28

    ElementInformationController.php:364 Reply

    Can you also add the change mentioned above in this comment regarding "creation_date" and "modification_date"?
  18. Daniel Goerz commented on patch set 3 01/05/17, 15:37

    This is always pixel isn't it? Should we append px to the numbers then?
  19. Daniel Goerz uploaded patch set 5 01/05/17, 15:46

  20. Daniel Goerz voted on patch set 5 CR +1 V +1 01/05/17, 15:47

  21. TYPO3com voted on patch set 5 V +1 01/05/17, 15:50 Completed build in 03m 55s on Thu, 5 Jan, 04:50 PM Test Summary: 54907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6232

  22. Markus Klein commented on patch set 5 01/05/17, 19:14

    2 wishes: - Can we put that into a single row in the table instead of two (it's a waste of space and at least I'm used 800x600 specification of dimensions) - Can we have this info directly in the filelist module as well (and also the the filebrowser?)
  23. Frans Saris commented on patch set 5 CR +1 V +1 01/11/17, 19:26

    Adding it as a new column to the filelist is a different task. I'm undecided about have the width and height as one row
  24. Christian Kuhn voted on patch set 5 CR +2 V +2 01/11/17, 21:07

  25. Gerrit merged patch set 5 01/11/17, 21:07