51054[FEATURE] Possibility to hide "tt_content_showHidden" in user's backend
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 4459
Show 2634 earlier messages
-
Michael Oehlhof uploaded patch set 1 12/28/16, 11:05
-
TYPO3com voted on patch set 1 V +1 12/28/16, 11:09 Completed build in 03m 42s on Wed, 28 Dec, 12:09 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6009
-
Mathias Schreiber commented on patch set 1 12/28/16, 11:57
PageLayoutView.php:78this has to be public? -
Michael Oehlhof uploaded patch set 2 12/28/16, 12:00
-
TYPO3com voted on patch set 2 V +1 12/28/16, 12:04 Completed build in 03m 50s on Wed, 28 Dec, 01:04 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6010
-
Philipp Gampe commented on patch set 2 12/28/16, 12:06
PageLayoutView.php:78why hidden by default -
Michael Oehlhof commented on patch set 3 12/28/16, 12:09
Published edit on patch set 2. -
TYPO3com voted on patch set 3 V +1 12/28/16, 12:13 Completed build in 03m 45s on Wed, 28 Dec, 01:13 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6011
-
Michael Oehlhof uploaded patch set 4 12/28/16, 13:35
-
TYPO3com voted on patch set 4 V +1 12/28/16, 13:40 Completed build in 04m 43s on Wed, 28 Dec, 02:40 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6014
-
Philipp Gampe commented on patch set 4 12/30/16, 15:52
Feature-63496-PossibiltyToHideTt_content_showHiddenInUsersBackend.rst:22This is a strange naming, I would prefer showHiddenContentElements, as the option is about showing elements and not about checking a checkbox. -
Benni Mack commented on patch set 4 05/10/17, 20:17
Could you please rebase? -
Michael Oehlhof uploaded patch set 5 05/11/17, 13:22
-
TYPO3com voted on patch set 5 V +1 05/11/17, 13:31 Completed build in 09m 10s on Thu, 11 May, 03:31 PM Test Summary: 55914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11403
-
Elmar Hinz commented on patch set 5 CR -1 05/13/17, 11:43
-1 for introduction of a new public property.PageLayoutController.php:814Even if this is consistent with the other public properties, like shown by this piece of code, I would not introduce new public properties for this reason only.PageLayoutView.php:78Introducing a public property. Altrenative is a protected one with getters and setters. -
Chris topher commented on patch set 5 05/13/17, 12:21
Your patch would introduce two different options, but they depend on each other. So wouldn't it make sense to combine the two into one? E.g. call the option showHiddenContentElements and give it the values - activated: The option is activated and the checkbox is hidden. - deactivated: The option is deactivated and the checkbox is hidden. - selectable: The checkbox is shown so that the option can be selected by the user. That way you don't have to create two separate options, which interfere with each other and the new option would also be streamlined with the options enableDisplayBigControlPanel, enableClipBoard and enableLocalizationView, which already exist. These options are working the same way already. -
Michael Oehlhof uploaded patch set 6 05/21/17, 17:23
-
Michael Oehlhof uploaded patch set 7 05/21/17, 17:25
-
TYPO3com voted on patch set 6 V +1 05/21/17, 17:29 Completed build in 06m 10s on Sun, 21 May, 07:29 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11661
-
TYPO3com voted on patch set 7 V +1 05/21/17, 17:31 Completed build in 05m 55s on Sun, 21 May, 07:31 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11662
-
Elmar Hinz voted on patch set 7 CR +1 05/21/17, 20:37
-
Riccardo De Contardi commented on patch set 7 V +1 05/28/17, 15:05
Verified with both PAGE TSconfig and USER TSconfig -
Sascha Rademacher voted on patch set 7 CR +1 V +1 08/07/17, 08:47
-
Jörg Bösche voted on patch set 7 CR +1 V +1 09/04/17, 07:06
-
Henning Liebe voted on patch set 7 CR +1 V +1 09/04/17, 08:01
-
Andreas Kienast commented on patch set 7 09/04/17, 08:09
I'm not sure whether we should introduce speaking names here. For the sake of concistency I'd rather use 1/0/-1, but that's a matter of personal taste. -
Christian Kuhn commented on patch set 7 CR -1 09/29/17, 15:39
Mmmmh, this introduces a setting for a setting. Ihmo, that's overkill. The checkbox (which i don't like in the first place) is only shown if there are actually hidden elements on the page. So this has been optimized already. Now disabling this altogether via pageTS imho does not give us much benefit and just adds another curious setting without much advantage. I'd rather skip that feature and suggest to think about the 'hidden' checkbox in the first place and if there is a better solution for the page module somehow to get rid of it entirely. -
Christian Kuhn commented on patch set 7 CR 0 09/29/17, 15:48
not a fan of this additional setting, but no -1, too. -
Mathias Schreiber commented on patch set 7 CR -1 V +1 09/29/17, 15:58
The value mod.web_layout.showHiddenContentElements = tippHaltIrgendwas results in the same behavior as the value "deactivated". So I found the very rare case of "yes it works, but the code is truly ugly". -
Michael Oehlhof uploaded patch set 8 11/22/17, 07:19
-
TYPO3com voted on patch set 8 V +1 11/22/17, 07:31 Completed build in 11m 10s on Wed, 22 Nov, 08:31 AM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16526
-
Riccardo De Contardi commented on patch set 8 V -1 02/01/18, 21:39
`mod.web_layout.showHiddenContentElements = 1` does not work - it removes the checkbox as the "0" value. Tested with both PageTS and UserTS -
Michael Oehlhof commented on patch set 9 02/23/18, 17:07
Published edit on patch set 8. -
Michael Oehlhof commented on patch set 9 02/23/18, 17:10
@Ricardo: It is correct that the checkbox is not shown when the mod.web_layout.showHiddenContentElements is set with value of 1 or 0. Depending on the value the hidden elements are shown (value = 1) or not shown (value = 0).
-
TYPO3com voted on patch set 9 V +1 02/23/18, 17:18 Completed build in 10m 07s on Fri, 23 Feb, 06:18 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20078
-
Riccardo De Contardi commented on patch set 9 V +1 02/23/18, 20:33
@Michael Oehlhof OK now I understand :) It works fine with both Page TSConfig and User TSConfig -
Riccardo De Contardi commented on patch set 10 02/23/18, 20:35
Published edit on patch set 9. -
TYPO3com voted on patch set 10 V +1 02/23/18, 20:46 Completed build in 11m 26s on Fri, 23 Feb, 09:46 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20081
-
Markus Klein updated the commit message in patch set 11 02/25/18, 23:19
-
Markus Klein commented on patch set 11 CR -1 02/25/18, 23:20
PageLayoutController.php:395can't we make this as simple as: $this->MOD_SETTINGS['tt_content_showHidden'] = !empty($this->modTSconfig['properties']['showHiddenContentElements']);PageLayoutController.php:830not needed if change above is done.PageLayoutController.php:8461.) no need for the extra parentheses. 2.) && $this->MOD_SETTINGS['tt_content_showHidden'] would be sufficient -
Markus Klein commented on patch set 11 02/25/18, 23:21
Feature-63496-PossibiltyToHideTt_content_showHiddenInUsersBackend.rst:4user'sFeature-63496-PossibiltyToHideTt_content_showHiddenInUsersBackend.rst:14please rephrase to avoid gender specific sentences -
TYPO3com voted on patch set 11 V +1 02/25/18, 23:27 Completed build in 08m 23s on Mon, 26 Feb, 12:27 AM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20129
-
Michael Oehlhof commented on patch set 11 02/25/18, 23:59
PageLayoutController.php:395Reply$this->modTSconfig['properties']['showHiddenContentElements'] can have 3 different values a) not defined, not existent b) 0 c) 1 Only for b) and c) $this->MOD_SETTINGS['tt_content_showHidden'] should be changed.PageLayoutController.php:846ReplyOK -
Michael Oehlhof uploaded patch set 12 02/26/18, 08:26
-
TYPO3com voted on patch set 12 V +1 02/26/18, 08:35 Completed build in 08m 23s on Mon, 26 Feb, 09:35 AM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20135
-
Markus Klein commented on patch set 12 CR -1 02/26/18, 09:20
Okay, the code with all this chained settings is really hard to understand and with the proposed TSconfig we lack one usecase: Admin configures globally via page TSconfig that hidden CEs are not shown, but wants an exception for a single user, who should see the checkbox. Unsetting a config again at a later point is very hard/impossible and very error prone. I therefore propose to switch this option to a tri-state: 0/1/user Defaulting to "user". This shall make the code more obvious to read an the configuration more straight-forward. -
Michael Oehlhof uploaded patch set 13 02/28/18, 19:15
-
TYPO3com voted on patch set 13 V +1 02/28/18, 19:24 Completed build in 09m 32s on Wed, 28 Feb, 08:24 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20318
-
Markus Klein commented on patch set 13 02/28/18, 20:38
PageLayoutController.php:394if this is set to "show", what is the int-cast supposed to do?PageLayoutController.php:839$enableShowHiddenCheckbox = !isset($this->modTSconfig['properties']['showHiddenContentElements']) || $this->modTSconfig['properties']['showHiddenContentElements'] === 'show'PageLayoutController.php:855no need for these ()Feature-63496-PossibiltyToHideTt_content_showHiddenInUsersBackend.rst:20I would go for: show hide user -
Michael Oehlhof uploaded patch set 14 03/01/18, 12:42
-
TYPO3com voted on patch set 14 V +1 03/01/18, 12:53 Completed build in 10m 20s on Thu, 1 Mar, 01:53 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20354
-
Michael Oehlhof commented on patch set 13 03/01/18, 13:03
PageLayoutController.php:394ReplyThat was overseenPageLayoutController.php:839ReplyOKPageLayoutController.php:855ReplyOKFeature-63496-PossibiltyToHideTt_content_showHiddenInUsersBackend.rst:20ReplyI thought 'user' could be misleading because you can set it not only for the user, also for the page. Therefor I used 'show' as key. 'show' was intended as "show the checkbox". -
Michael Oehlhof commented on patch set 13 03/01/18, 13:08
Feature-63496-PossibiltyToHideTt_content_showHiddenInUsersBackend.rst:20ReplyHow should a wrong setting be handled? mod.web_layout.showHiddenContentElements = blablub Like if it is not set (that's the default) => works like 'show'? -
Anja Leichsenring uploaded patch set 15 04/14/18, 14:44
-
Anja Leichsenring commented on patch set 15 V -1 04/14/18, 14:48
rebased, works as advertised, but any invalid input to the PageTS/UserTS setting will hide the checkbox from view. This should not be the case, have it fall back to 'show'. -
TYPO3com voted on patch set 15 V +1 04/14/18, 14:53 Completed build in 08m 41s on Sat, 14 Apr, 04:53 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22325
-
Anja Leichsenring commented on patch set 15 04/14/18, 14:56
I don't like this option at all. It should, if at all, be something like 'displayShowHiddenTtContentCheckbox' with the values true or false, nothing else. Putting two settings into one option (show hidden CEs, and display the checkbox) is just confusing. -
Michael Oehlhof commented on patch set 15 04/19/18, 07:54
> Patch Set 15: > > I don't like this option at all. It should, if at all, be something like 'displayShowHiddenTtContentCheckbox' with the values true or false, nothing else. Putting two settings into one option (show hidden CEs, and display the checkbox) is just confusing. Maybe add a second option 'showHiddenTtContentCheckboxDefaultValueIfHidden' . -
Benni Mack abandoned the change 10/27/18, 20:57
Although a lot of work has been put in this change, I opt for not adding this feature/option. See the comments in the issue: a) The behaviour has been improved in the last versions already b) Removing the option was compared to clipboard (which _is_ a completely different UX case) - one is showing a tool for BE editing, and the other one relates to a DB query.
PageLayoutController.php:1115