Review main Merged

51055[TASK] Split fluid styled content rendering definitions

Benjamin Kott CR +2 V +2 Hard +269 −210 updated 12/29/16, 14:56

Commit message

Moving the rendering definitions for content elements to dedicated
files provides a better overview over the configuration and creates
a single responsibility per configuration file.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Tobias Wollender +1
    • Michael Oehlhof +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 912

  1. Benjamin Kott uploaded patch set 1 12/28/16, 23:37

  2. TYPO3com voted on patch set 1 V +1 12/28/16, 23:42 Completed build in 04m 08s on Thu, 29 Dec, 12:42 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6024

  3. Benjamin Kott uploaded patch set 2 12/28/16, 23:43

  4. Benjamin Kott uploaded patch set 3 12/28/16, 23:45

  5. TYPO3com voted on patch set 2 V +1 12/28/16, 23:47 Completed build in 04m 15s on Thu, 29 Dec, 12:47 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6025

  6. TYPO3com voted on patch set 3 V +1 12/28/16, 23:50 Completed build in 05m 13s on Thu, 29 Dec, 12:50 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6026

  7. Michael Oehlhof voted on patch set 3 CR +1 12/29/16, 07:25

  8. Susi Moog voted on patch set 3 CR +1 V +1 12/29/16, 10:57

  9. Tobias Wollender commented on patch set 3 CR +1 12/29/16, 12:43

    Why don't you include the whole ContentElement directory in setup.txt with one include? <INCLUDE_TYPOSCRIPT: source="DIR:EXT:fluid_styled_content/Configuration/TypoScript/ContentElement/">
  10. Benjamin Kott commented on patch set 3 12/29/16, 13:02

    Includes are done manually to keep control over the loading order. In this case the default fallback is loaded last. It does not have a big impact for now, but will get more relevant later when starting optimizing and elements get splittet even more like the menu stuff for example.
  11. Christian Kuhn commented on patch set 3 CR +2 V +2 12/29/16, 14:56

    i prefer loading of single files, too. will merge patch.
  12. Gerrit merged patch set 3 12/29/16, 14:56