51055[TASK] Split fluid styled content rendering definitions
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Tobias Wollender +1
- Michael Oehlhof +1
- Susi Moog +1
-
Verified V +2
- Christian Kuhn +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 12
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Bullets.txtnew+38 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Default.txtnew+7 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Div.txtnew+9 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Header.txtnew+16 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Html.txtnew+16 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/List.txtnew+15 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Menu.txtnew+33 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Shortcut.txtnew+23 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Table.txtnew+32 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Textmedia.txtnew+29 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Uploads.txtnew+23 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/Static/setup.txt+28 −210
Review log 912
-
Benjamin Kott uploaded patch set 1 12/28/16, 23:37
-
TYPO3com voted on patch set 1 V +1 12/28/16, 23:42 Completed build in 04m 08s on Thu, 29 Dec, 12:42 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6024
-
Benjamin Kott uploaded patch set 2 12/28/16, 23:43
-
Benjamin Kott uploaded patch set 3 12/28/16, 23:45
-
TYPO3com voted on patch set 2 V +1 12/28/16, 23:47 Completed build in 04m 15s on Thu, 29 Dec, 12:47 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6025
-
TYPO3com voted on patch set 3 V +1 12/28/16, 23:50 Completed build in 05m 13s on Thu, 29 Dec, 12:50 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6026
-
Michael Oehlhof voted on patch set 3 CR +1 12/29/16, 07:25
-
Susi Moog voted on patch set 3 CR +1 V +1 12/29/16, 10:57
-
Tobias Wollender commented on patch set 3 CR +1 12/29/16, 12:43
Why don't you include the whole ContentElement directory in setup.txt with one include? <INCLUDE_TYPOSCRIPT: source="DIR:EXT:fluid_styled_content/Configuration/TypoScript/ContentElement/"> -
Benjamin Kott commented on patch set 3 12/29/16, 13:02
Includes are done manually to keep control over the loading order. In this case the default fallback is loaded last. It does not have a big impact for now, but will get more relevant later when starting optimizing and elements get splittet even more like the menu stuff for example. -
Christian Kuhn commented on patch set 3 CR +2 V +2 12/29/16, 14:56
i prefer loading of single files, too. will merge patch. -
Gerrit merged patch set 3 12/29/16, 14:56