51056[BUGFIX] Determine Chinese simplified Han "Accept-Language" header
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Oliver Hader +1
-
Verified V +2
- Christian Kuhn +2
- Oliver Hader +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2942
Show 1117 earlier messages
-
TYPO3com uploaded patch set 1 12/29/16, 09:02
-
TYPO3com voted on patch set 1 V -1 12/29/16, 09:06 Completed build in 03m 49s on Thu, 29 Dec, 10:06 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6029
-
Mathias Schreiber commented on patch set 2 12/29/16, 09:13
Published edit on patch set 1. -
Mathias Schreiber commented on patch set 2 12/29/16, 09:15
I'm pretty certain (80%) that it should say "CN", not "CH". Fixed some CGL issues along the line. -
TYPO3com voted on patch set 2 V -1 12/29/16, 09:17 Completed build in 04m 09s on Thu, 29 Dec, 10:17 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6030
-
Mathias Schreiber commented on patch set 3 12/29/16, 11:42
Published edit on patch set 2. -
Mathias Schreiber commented on patch set 3 12/29/16, 11:42
after checking back with David on Slack it turns out that translation.typo3.org indeed uses "ch" to identify chinese as a language. -
TYPO3com voted on patch set 3 V -1 12/29/16, 11:46 Completed build in 04m 06s on Thu, 29 Dec, 12:46 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6033
-
Jörg Bösche uploaded patch set 4 07/12/17, 08:45
-
TYPO3com voted on patch set 4 V +1 07/12/17, 08:54 Completed build in 09m 41s on Wed, 12 Jul, 10:54 AM Test Summary: 56781 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13091
-
Georg Ringer commented on patch set 4 CR -1 07/12/17, 12:46
issue is missing and I guess should also go into 8.7 -
Jörg Bösche updated the commit message in patch set 5 07/13/17, 16:44
-
Susi Moog commented on patch set 5 CR -1 07/13/17, 16:49
just nit-picky for demonstration purpose ;)has changed.Locales.php:248space missing. -
Frank Nägler commented on patch set 5 CR -1 07/13/17, 16:54
Locales.php:248ReplyAnd start with an uppercase "f"... // Fix ... -
TYPO3com voted on patch set 5 V +1 07/13/17, 16:54 Completed build in 10m 06s on Thu, 13 Jul, 06:54 PM Test Summary: 56781 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13115
-
Andreas Kienast commented on patch set 6 07/13/17, 16:55
Published edit on patch set 5. -
Oliver Hader commented on patch set 6 CR +1 07/13/17, 16:58
Thx Andi for adjusting, will test later this evening...Locales.php:248ReplyGood catch...
-
Susi Moog updated the commit message in patch set 7 07/13/17, 16:58
-
Andreas Kienast voted on patch set 7 CR +1 07/13/17, 16:59
-
Jan Helke voted on patch set 7 CR +1 07/13/17, 17:01
-
TYPO3com voted on patch set 6 V +1 07/13/17, 17:07 Completed build in 11m 39s on Thu, 13 Jul, 07:07 PM Test Summary: 56781 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13116
-
TYPO3com voted on patch set 7 V +1 07/13/17, 17:11 Completed build in 12m 31s on Thu, 13 Jul, 07:11 PM Test Summary: 56781 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13117
-
Robert Heinig Temp rebased onto patch set 8 07/14/17, 20:57
-
TYPO3com voted on patch set 8 V +1 07/14/17, 21:03 Completed build in 06m 01s on Fri, 14 Jul, 11:03 PM Test Summary: 19022 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13200
-
Benni Mack uploaded patch set 9 09/09/17, 23:31
-
Benni Mack commented on patch set 9 09/09/17, 23:36
Locales.php:115we should probably to a strtolower() to all isos -
TYPO3com voted on patch set 9 V +1 09/09/17, 23:46 Completed build in 15m 31s on Sun, 10 Sep, 01:46 AM Test Summary: 58146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14762
-
Stefan Neufeind commented on patch set 9 09/10/17, 13:59
It seems besides zh-hans there is also zh-hant defined? Some more links: https://github.com/mozilla/persona/issues/3044 https://www.w3.org/International/articles/bcp47/ -
Stefan Neufeind commented on patch set 9 09/10/17, 14:05
Locales.php:115Replyadded a separate issue for that: https://forge.typo3.org/issues/82446 -
Oliver Hader commented on patch set 9 CR -2 11/29/17, 13:56
This patch and the whole (existing) implementation does not seem to be correct - I'll try to provide tests for that -
Oliver Hader uploaded patch set 10 11/29/17, 14:13
-
Oliver Hader commented on patch set 10 V -1 11/29/17, 14:15
The adjusted test cases show that the new zh-Hans-CN assignment overrides the possibility to detect zh_CN correctly. The reason for that is obvious, array_flip uses the last assignment in the reverse mapping only -
TYPO3com voted on patch set 10 V -1 11/29/17, 14:23 Completed build in 09m 09s on Wed, 29 Nov, 03:23 PM Test Summary: 6 of 57227 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16956
-
Oliver Hader uploaded patch set 11 11/29/17, 14:27
-
Oliver Hader voted on patch set 11 CR +1 11/29/17, 14:27
-
Oliver Hader uploaded patch set 12 11/29/17, 14:31
-
Oliver Hader voted on patch set 12 CR +1 V +1 11/29/17, 14:31
-
TYPO3com voted on patch set 11 V +1 11/29/17, 14:38 Completed build in 11m 04s on Wed, 29 Nov, 03:38 PM Test Summary: 56868 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16959
-
TYPO3com voted on patch set 12 V +1 11/29/17, 14:42 Completed build in 11m 40s on Wed, 29 Nov, 03:42 PM Test Summary: 56868 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16960
-
Christian Kuhn voted on patch set 12 CR +2 V +2 11/29/17, 15:10
-
Gerrit merged patch set 12 11/29/17, 15:10
-
Christian Kuhn commented on patch set 13 11/29/17, 15:10
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 776c81669849853302a01c77cc8efdb42152d58f