Review main Merged

51059[BUGFIX] Change EM composer mode message to info level

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 01/28/17, 11:14

Commit message

As https://review.typo3.org/#/c/44025/ enabled extensionmanager
offline mode for composer installations, the composer mode message
should no longer be a warning but an info.

Review

  • Code review CR +2
    • Philipp Gampe +2
    • Georg Ringer +1
    • Susi Moog +1
  • Verified V +2
    • Philipp Gampe +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Files 1

Review log 1213

  1. Benjamin Franzke uploaded patch set 1 12/29/16, 12:26

  2. TYPO3com voted on patch set 1 V +1 12/29/16, 12:30 Completed build in 04m 05s on Thu, 29 Dec, 01:30 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6035

  3. Georg Ringer voted on patch set 1 CR +1 V +1 12/30/16, 12:28

  4. Nicole Hummel commented on patch set 1 12/30/16, 23:49

    I tend to not change the status of the message. 1) the information could not be visible enough. 2) This is the reason a few functions are disabled in EM with composer mode. 3) It may be even wrong/bad practice to install/uninstall extensions in EM as this might be done by composer (or deployment)
  5. Benjamin Franzke commented on patch set 1 12/31/16, 05:46

    > I tend to not change the status of the message. 1) the information > could not be visible enough. Well, that's subjective. I don't think so, but you do, ok.. But if that'd be the only reason, the info box color should be changed. > 2) This is the reason a few functions > are disabled in EM with composer mode. Yeah, and that's fine. But that can't be a warning. That's semantically incorrect. A warning implies that the integrator has done something wrong. That means a warning should be resolvable by doing it right. But this warning can't be resolved, besides by using classic mode – which isn't the intention of that message. > 3) It may be even wrong/bad > practice to install/uninstall extensions in EM as this might be > done by composer (or deployment) The Messages states "The system is set to composer mode. Please notice that it is not possible to add an extension with the Extension Manager. You have to use composer to add further extensions to your system." The "warning" doesn't talk about bad practice of installing extensions using EM or not – only about adding. So i don't think your argument about install/uninstall applies here. That's another topic.
  6. Mathias Schreiber commented on patch set 1 12/31/16, 10:04

    A proper compromise would be to adjust the message in the process. I do agree with Nicole that the message is important to understand, but OTOH I agree with Benjamin that "understanding" does not rely on the coloring of the message. A more verbose message with Nicoles remarks but with the severity level of "Info" feels right to me.
  7. Nicole Hummel commented on patch set 1 12/31/16, 10:04

    Maybe you understand my point of view better, if you don't associate the warning as something a user has to change but as kind of asking for your attention. IMHO there are many warnings out there in the wild, telling you you should care about something (like at the train station or in hospitals).
  8. Benjamin Franzke commented on patch set 1 12/31/16, 11:56

    > Maybe you understand my point of view better, if you don't > associate the warning as something a user has to change but as kind > of asking for your attention. But "something has to be changed" is exactly what a both technical and non-technical warning is about,. You're changing the definition of a warning here. > IMHO there are many warnings out > there in the wild, telling you you should care about something > (like at the train station or in hospitals). 1. As this is about a technical message (for developers), we shouldn't compare with non-technical warnings, but take other usecases in programming/logging. 2. And even in those "real life" comparisions you're talking about, one would use an informational icon/banner/whatever.. Looking at https://en.wikipedia.org/wiki/Precautionary_statement I figure that you probably want/need a "caution" flag. But a warning is something different and the info-level is the best match for a "caution"-message.
  9. Nicole Hummel commented on patch set 1 12/31/16, 13:07

    Feel free to whatever you want. Thanks for listing to my arguments. I'm away from this patch.
  10. Susi Moog voted on patch set 1 CR +1 01/27/17, 19:18

  11. Philipp Gampe voted on patch set 1 CR +2 V +2 01/28/17, 11:13

  12. Gerrit merged patch set 1 01/28/17, 11:14

  13. Philipp Gampe commented on patch set 2 01/28/17, 11:14

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 470da29246b0941388f729311f63307fd5b0ee12