Review main Merged

51061[BUGFIX] Properly handle flexform related exceptions

Alexander Schnitzler CR +2 V +2 Normal +74 −20 updated 11/29/17, 19:13

Commit message

The FlexFormTools class tries to resolve the datastructure
of flex fields by the given TCA configuration. The flexform
definition can either be set directly in the TCA or it is
fetched from another record.

Example:
TemplaVoilà fetches the data structure from the table
tx_templavoila_datastructure.

When trying to resolve the data structure from another
table and the identifier is invalid (e.g. empty or does
not point to a valid record), several exceptions are
thrown that need to be caught at several points to keep
the user interface accessible.

Other than these mentioned exceptions there are ones
that indicate that the TCA configuration is simply wrong.
These ones are not caught and will still bubble up.

Review

  • Code review CR +2
    • Susi Moog +2
    • Christian Kuhn +1
  • Verified V +2
    • Susi Moog +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Files 3

Review log 1216

  1. Alexander Schnitzler uploaded patch set 1 12/29/16, 14:50

  2. TYPO3com voted on patch set 1 V +1 12/29/16, 14:55 Completed build in 04m 31s on Thu, 29 Dec, 03:55 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6041

  3. Christian Kuhn commented on patch set 1 CR -1 12/29/16, 14:58

    thx alexander, we talked about that one already. will review in detail after my current wip patch, shouldn't be merged before. -1 until then.
  4. Alexander Schnitzler uploaded patch set 2 03/20/17, 08:50

  5. TYPO3com voted on patch set 2 V +1 03/20/17, 08:59 Completed build in 08m 21s on Mon, 20 Mar, 09:59 AM Test Summary: 56527 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9350

  6. Alexander Schnitzler commented on patch set 2 09/14/17, 13:33

    Any news here, Christian?
  7. Christian Kuhn commented on patch set 2 CR -1 11/29/17, 17:36

    sorry for the delay ...
  8. Christian Kuhn rebased onto patch set 3 11/29/17, 17:36

  9. Christian Kuhn commented on patch set 3 CR -1 11/29/17, 17:37

    rebased. reviewing.
  10. Christian Kuhn uploaded patch set 4 11/29/17, 17:47

  11. Christian Kuhn voted on patch set 4 CR +1 V +1 11/29/17, 17:49

  12. TYPO3com voted on patch set 3 V +1 11/29/17, 17:52 Completed build in 15m 14s on Wed, 29 Nov, 06:52 PM Test Summary: 57002 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17003

  13. TYPO3com voted on patch set 4 V +1 11/29/17, 18:05 Completed build in 18m 20s on Wed, 29 Nov, 07:05 PM Test Summary: 57002 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17009

  14. Susi Moog voted on patch set 4 CR +2 V +2 11/29/17, 19:12

  15. Gerrit merged patch set 4 11/29/17, 19:12

  16. Christian Kuhn commented on patch set 5 11/29/17, 19:13

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 205e3552d9ecb1ac35de8bafdb7301d2b59b26b0