Review main Merged

51063[TASK] Remove unused property in PageRepository

Benni Mack CR +2 V +2 Easy +14 −5 updated 12/30/16, 16:09

Commit message

The public property $versioningPreview_where_hid_del
is not in use anymore due to the refactoring of
Doctrine DBAL and can be removed, as it is always
empty and not used in the TYPO3 Core.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Wouter Wolters +1
  • Verified V +2
    • Nicole Hummel +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Benni Mack uploaded patch set 1 12/29/16, 16:01

  2. Benni Mack commented on patch set 1 12/29/16, 16:03

    Since this is public, should we add a breaking RST?
  3. TYPO3com voted on patch set 1 V +1 12/29/16, 16:06 Completed build in 04m 49s on Thu, 29 Dec, 05:06 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6048

  4. Nicole Hummel commented on patch set 1 12/29/16, 22:23

    I had a look in the source and TER extensions. I opt to remove this property completely. IMHO there is no good way how to deprecate the property.
  5. Benni Mack uploaded patch set 2 12/30/16, 13:21

  6. Wouter Wolters voted on patch set 2 CR +1 V +1 12/30/16, 13:23

  7. TYPO3com voted on patch set 2 V +1 12/30/16, 13:25 Completed build in 03m 55s on Fri, 30 Dec, 02:25 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6068

  8. Nicole Hummel voted on patch set 2 CR +2 V +2 12/30/16, 16:08

  9. Gerrit merged patch set 2 12/30/16, 16:09