51066[BUGFIX] Add separate sorting direction to getMenu methods
Commit message
Review
-
Code review CR +2
- Morton Jonuschat +2
- Wouter Wolters +1
- Benjamin Kott +1
-
Verified V +2
- Morton Jonuschat +2
- Riccardo De Contardi +1
- Benjamin Kott +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1519
-
Susi Moog uploaded patch set 1 12/29/16, 22:14
-
Susi Moog uploaded patch set 2 12/29/16, 22:15
-
TYPO3com voted on patch set 1 V -1 12/29/16, 22:17 Completed build in 03m 42s on Thu, 29 Dec, 11:17 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6057
-
TYPO3com voted on patch set 2 V +1 12/29/16, 22:20 Completed build in 04m 46s on Thu, 29 Dec, 11:20 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6058
-
Benjamin Kott voted on patch set 2 CR +2 V +2 12/29/16, 22:24
-
Morton Jonuschat commented on patch set 2 CR -1 12/29/16, 23:19
We should fix getMenuForPages() to properly parse the $sortField using the methods in QueryHelper instead of adding additional params -
Morton Jonuschat commented on patch set 2 12/29/16, 23:20
> We should fix getMenuForPages() to properly parse the $sortField > using the methods in QueryHelper instead of adding additional > params I mean getSubpagesForPages() -
Susi Moog commented on patch set 2 CR -2 12/29/16, 23:32
will do, thanks for the pointer. -
Benjamin Kott voted on patch set 2 CR 0 V 0 12/29/16, 23:33
-
Susi Moog uploaded patch set 3 12/30/16, 08:41
-
Susi Moog voted on patch set 3 CR 0 12/30/16, 08:41
-
TYPO3com voted on patch set 3 V -1 12/30/16, 08:45 Completed build in 03m 44s on Fri, 30 Dec, 09:45 AM Test Summary: 8 of 54417 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6060
-
Susi Moog uploaded patch set 4 12/30/16, 08:45
-
TYPO3com voted on patch set 4 V +1 12/30/16, 08:50 Completed build in 04m 15s on Fri, 30 Dec, 09:50 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6061
-
Riccardo De Contardi voted on patch set 4 V +1 12/30/16, 09:29
-
Benjamin Kott voted on patch set 4 CR +1 V +1 12/30/16, 09:42
-
Wouter Wolters voted on patch set 4 CR +1 12/30/16, 09:46
-
Morton Jonuschat voted on patch set 4 CR +2 V +2 12/30/16, 10:20
-
Gerrit merged patch set 4 12/30/16, 10:20