Review main Merged

51067[BUGFIX] CE "menu" subtype "keywords" generated wrong SQL

Susi Moog CR +2 V +2 Normal +47 −13 updated 12/30/16, 16:02

Commit message

When using the content element Menu with subtype "keywords"
the generated SQL contained non-replaced prepared statement
params resulting in a query error.

The whole query was rewritten to use the doctrine query builder directly.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Benjamin Kott +1
  • Verified V +2
    • Morton Jonuschat +2
    • Benjamin Kott +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 811

  1. Susi Moog uploaded patch set 1 12/30/16, 08:52

  2. TYPO3com voted on patch set 1 V -1 12/30/16, 08:56 Completed build in 04m 14s on Fri, 30 Dec, 09:56 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6062

  3. Susi Moog uploaded patch set 2 12/30/16, 09:05

  4. TYPO3com voted on patch set 2 V +1 12/30/16, 09:09 Completed build in 03m 35s on Fri, 30 Dec, 10:09 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6063

  5. Benjamin Kott commented on patch set 2 CR -1 12/30/16, 10:31

    the "extraWhere" conditions are currently missing in the migration
  6. Morton Jonuschat commented on patch set 2 CR -1 12/30/16, 10:31

    On it
  7. Morton Jonuschat uploaded patch set 3 12/30/16, 10:51

  8. TYPO3com voted on patch set 3 V +1 12/30/16, 10:56 Completed build in 04m 24s on Fri, 30 Dec, 11:56 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6066

  9. Benjamin Kott commented on patch set 3 CR +1 V +1 12/30/16, 14:16

    works fine
  10. Morton Jonuschat voted on patch set 3 CR +2 V +2 12/30/16, 16:02

  11. Gerrit merged patch set 3 12/30/16, 16:02