Review main Merged

51075[FEATURE] Allow modification of typolink params

Mathias Schreiber CR +2 V +2 Normal +111 −17 updated 12/31/16, 12:43

Commit message

Added a hook to typolink if link type is "page" to be able
to modify page links (for example enriching them with further
information from the current page row).

Review

  • Code review CR +2
    • Benni Mack +2
    • Mathias Schreiber +1
  • Verified V +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 811

  1. Mathias Schreiber uploaded patch set 1 12/30/16, 16:52

  2. TYPO3com voted on patch set 1 V +1 12/30/16, 16:56 Completed build in 03m 56s on Fri, 30 Dec, 05:56 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6087

  3. Benni Mack commented on patch set 1 12/30/16, 21:11

    ContentObjectRenderer.php:5913

    use makeInstance() instead, getUserObj() will be deprecated in v9.

    ContentObjectRenderer.php:5918

    the hook does not allow other options set before (pageType, sectionMark etc) which have been defined before to be changed, which could be a viable use-case as well (modifying the hard-coded "#c" of sectionMark is a pain. Do you think this should be modified as well? Also, I think we should hand over $linkDetails as well.

    ContentObjectRenderer.php:5921

    what is $foo?
  4. Susi Moog uploaded patch set 2 12/31/16, 09:22

  5. Susi Moog commented on patch set 2 12/31/16, 09:24

    After analyzing what's happening a bit, I moved some stuff around so that the hook is able to also modify sectionmark etc. - additional benefit is that the config for sectionmark, linksacrossdomanis ... is only loaded if the vars are used later. Also added a .rst with an implementation example.
  6. TYPO3com voted on patch set 2 V +1 12/31/16, 09:26 Completed build in 04m 08s on Sat, 31 Dec, 10:26 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6102

  7. Mathias Schreiber commented on patch set 3 12/31/16, 09:52

    Published edit on patch set 2.
  8. Mathias Schreiber commented on patch set 3 CR +1 V +1 12/31/16, 09:52

    Fixed RST formatting. Thank you for following up.
  9. TYPO3com voted on patch set 3 V +1 12/31/16, 09:56 Completed build in 03m 53s on Sat, 31 Dec, 10:56 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6103

  10. Benni Mack voted on patch set 3 CR +2 V +2 12/31/16, 12:43

  11. Gerrit merged patch set 3 12/31/16, 12:43