Review main Merged

51076[TASK] Restructure typolink tag generation

Benni Mack CR +2 V +2 Normal +35 −33 updated 03/30/17, 22:37

Commit message

Information for creating the target and the class information etc. is
spread through the main function. Putting everything in one place and
using an array for building the <a> tag seems to be more appropriate.

The functionality for building the tag could now be moved in to a
separate function in a next step. Alternative would be to move the
resolving of the "target" field into a separate method.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 914

  1. Benni Mack uploaded patch set 1 12/30/16, 22:24

  2. TYPO3com voted on patch set 1 V +1 12/30/16, 22:28 Completed build in 04m 08s on Fri, 30 Dec, 11:28 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6090

  3. Benni Mack uploaded patch set 2 01/18/17, 18:03

  4. TYPO3com voted on patch set 2 V +1 01/18/17, 18:08 Completed build in 04m 34s on Wed, 18 Jan, 07:08 PM Test Summary: 54981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6784

  5. Josef Glatz updated the commit message in patch set 3 01/18/17, 22:48

  6. TYPO3com voted on patch set 3 V +1 01/18/17, 22:53 Completed build in 04m 33s on Wed, 18 Jan, 11:53 PM Test Summary: 54981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6802

  7. Benni Mack updated the commit message in patch set 4 02/15/17, 17:34

  8. TYPO3com voted on patch set 4 V +1 02/15/17, 17:40 Completed build in 05m 39s on Wed, 15 Feb, 06:40 PM Test Summary: 56289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8102

  9. Benni Mack updated the commit message in patch set 5 03/30/17, 20:46

  10. Frank Nägler voted on patch set 5 CR +1 V +1 03/30/17, 20:50

  11. TYPO3com voted on patch set 5 V +1 03/30/17, 20:56 Completed build in 09m 18s on Thu, 30 Mar, 10:56 PM Test Summary: 56555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9989

  12. Christian Kuhn commented on patch set 5 03/30/17, 22:30

    ContentObjectRenderer.php:6116

    bug here
  13. Christian Kuhn commented on patch set 5 CR +2 V +2 03/30/17, 22:37

    ContentObjectRenderer.php:6116 Reply

    no, is ok.
  14. Gerrit merged patch set 5 03/30/17, 22:37