51077[!!!][TASK] Move pages.url_scheme to compatibility7
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Christian Kuhn +1
-
Verified V +2
- Susi Moog +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 14
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −8
- typo3/sysext/compatibility7/Classes/Hooks/EnforceUrlSchemeHook.phpnew+89 −0
- typo3/sysext/compatibility7/Configuration/TCA/Overrides/pages.phpnew+33 −0
- typo3/sysext/compatibility7/Resources/Private/Language/locallang_tca.xlfnew+20 −0
- typo3/sysext/compatibility7/ext_localconf.php+7 −0
- typo3/sysext/compatibility7/ext_tables.sqlnew+6 −0
- typo3/sysext/core/Configuration/TCA/pages.php+2 −25
- typo3/sysext/core/Documentation/Changelog/master/Breaking-79302-MovedPagesurlSchemeToCompatibility7Extension.rstnew+43 −0
- typo3/sysext/core/Tests/Functional/Tca/PagesVisibleFieldsTest.php+0 −4
- typo3/sysext/core/ext_tables.sql+0 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+1 −4
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+0 −19
- typo3/sysext/frontend/Resources/Private/Language/locallang_tca.xlf+0 −12
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+1 −5
Review log 1923
-
Benni Mack uploaded patch set 1 12/30/16, 22:34
-
Benni Mack commented on patch set 1 12/30/16, 22:36
Furthermore, I consider this functionality very non-user-friendly as most editors don't really have to deal with this option nor do they understand it as it is available in the page properties. I know a use-case with certain multiple domains and a SSL-enforced domain for certain pages, but this seems to be 1% of the user-basis (IMHO) -
TYPO3com voted on patch set 1 V -1 12/30/16, 22:39 Completed build in 04m 39s on Fri, 30 Dec, 11:39 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6091
-
Benni Mack commented on patch set 1 12/30/16, 22:41
I could also move it to compatibility7 with certain hooks in place. -
Tymoteusz Motylewski commented on patch set 1 12/30/16, 23:25
one more argument for having ssl everywhere is that google is promoting sites with ssl enabled in the search ranking. How will TYPO3 know whether to create cross domain link with https or http? Probably we will need to add a field to the domain record? -
Benni Mack commented on patch set 1 12/30/16, 23:27
There is also a simplified solution in the TER: https://github.com/CMSExperts/simplessl - could solve most of people's problems if they don't have access to .htaccess. -
Benni Mack uploaded patch set 2 01/12/17, 14:29
-
TYPO3com voted on patch set 2 V +1 01/12/17, 14:35 Completed build in 06m 04s on Thu, 12 Jan, 03:35 PM Test Summary: 54939 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6576
-
Benni Mack uploaded patch set 3 01/12/17, 18:01
-
TYPO3com voted on patch set 3 V +1 01/12/17, 18:05 Completed build in 04m 12s on Thu, 12 Jan, 07:05 PM Test Summary: 54939 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6589
-
Georg Ringer voted on patch set 3 CR +1 01/12/17, 18:08
-
Susi Moog voted on patch set 3 CR +1 01/12/17, 18:32
-
Markus Klein commented on patch set 3 01/12/17, 18:41
Hm... I'm actually not sure if this is a good idea. Consider a page where the scheme is something specific, eg a stream or so. This can be handy inside intranets for instance. -
Susi Moog commented on patch set 3 01/12/17, 18:52
@markus: the url scheme is a dropdown where you can select "http" or "https" or "default". do you think people have extended that field with something else or how would one use that for a stream? -
Benni Mack commented on patch set 3 01/12/17, 19:28
@Markus: Yes, that's my point of the patch - i would really say that this field / functionality is part for 1%. If you use url_scheme as it is right now, and extend it with another scheme (like 2=ftp://) the frontend *would* fail to detect if it should redirect to that, that's my impression. And the trade-off for having this field enabled for everybody who installs TYPO3 by default and have it in the page properties enabled is really important. So this change helps a lot of people new to TYPO3 to have a better overview. Plus: The functionality is still there for those who need it, but they'd need to install compatibility7, which is currently not such a huge slow-down as we mentioned with compatibility6 (with all class aliases etc). -
Markus Klein commented on patch set 3 01/12/17, 21:52
Alright, maybe my example is really too edge'y. I had a real usecase once, where we set this dropdown to https and there was no other sane solution than that. But I totally fail to recall the details currently and therefore... let it go, let it go, let it snow ;-) -
Christian Kuhn voted on patch set 3 CR +1 V +1 01/12/17, 23:04
-
Christian Kuhn commented on patch set 3 CR -1 01/12/17, 23:17
looking for an issue ... -
Christian Kuhn uploaded patch set 4 01/12/17, 23:28
-
Christian Kuhn commented on patch set 4 CR +1 V +1 01/12/17, 23:29
minor issue fixed. -
TYPO3com voted on patch set 4 V +1 01/12/17, 23:33 Completed build in 05m 20s on Fri, 13 Jan, 12:33 AM Test Summary: 54939 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6603
-
Susi Moog voted on patch set 4 CR +2 V +2 01/13/17, 08:47
-
Gerrit merged patch set 4 01/13/17, 08:47