Review TYPO3_7-6 Merged

51083[BUGFIX] Do not use realpath for temporary file names

Helmut Hummel CR +2 V +2 Easy +1 −1 updated 12/31/16, 18:22

Commit message

Generating a temporary file with the PHP function tempnam,
returns the realpath of the file. There are however
situations where PATH_site has some symlinks or mounts, thus
comparing those paths will fail.

Instead of just using the path the function returns, we only
use the filename and prefix that with PATH_site, so that
the check if the temporary path is within PATH_site will succeed.

Review

  • Code review CR +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2

Issues 1

Files 1

Review log 45

  1. Helmut Hummel commented on patch set 1 12/31/16, 18:18

    Cherry Picked from branch master.
  2. Helmut Hummel voted on patch set 1 CR +2 V +2 12/31/16, 18:20

  3. Helmut Hummel commented on patch set 1 12/31/16, 18:21

    straight pick
  4. Gerrit merged patch set 1 12/31/16, 18:21

  5. TYPO3com commented on patch set 1 12/31/16, 18:22 Completed build in 03m 34s on Sat, 31 Dec, 07:22 PM Test Summary: 38338 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-566