Review TYPO3_6-2 Merged

51086[BUGFIX] Do not use realpath for temporary file names

Helmut Hummel CR +2 V +2 Easy +1 −1 updated 12/31/16, 22:23

Commit message

Generating a temporary file with the PHP function tempnam,
returns the realpath of the file. There are however
situations where PATH_site has some symlinks or mounts, thus
comparing those paths will fail.

Instead of just using the path the function returns, we only
use the filename and prefix that with PATH_site, so that
the check if the temporary path is within PATH_site will succeed.

Review

  • Code review CR +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Helmut Hummel uploaded patch set 1 12/31/16, 22:16

  2. Helmut Hummel voted on patch set 1 CR +2 V +2 12/31/16, 22:16

  3. TYPO3com voted on patch set 1 V +1 12/31/16, 22:21 Completed build in 04m 21s on Sat, 31 Dec, 11:21 PM Test Summary: 30884 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC6-89

  4. Gerrit merged patch set 1 12/31/16, 22:23