Review main Merged

51096[BUGFIX] Use correct type in PageRepository::getDomainStartPage for column fe_group

Manuel Selbach CR +2 V +2 Easy +1 −1 updated 01/03/17, 06:06

Commit message

Strict DBMS will throw an exception for a query where to compare an integer against a column with string values.
There will no "magic" type casting processed, thus we have to use a string instead of an integer.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Morton Jonuschat +1
  • Verified V +2
    • Georg Ringer +2
    • Morton Jonuschat +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Manuel Selbach uploaded patch set 1 01/02/17, 14:17

  2. TYPO3com voted on patch set 1 V +1 01/02/17, 14:22 Completed build in 05m 00s on Mon, 2 Jan, 03:22 PM Test Summary: 54437 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6159

  3. Morton Jonuschat voted on patch set 1 CR +1 V +1 01/02/17, 23:27

  4. Georg Ringer voted on patch set 1 CR +2 V +2 01/03/17, 06:06

  5. Gerrit merged patch set 1 01/03/17, 06:06