Review main Merged

51106[FEATURE] Add hook to add custom TypoScript templates

Benni Mack CR +2 V +2 Normal +79 −0 updated 01/11/17, 17:37

Commit message

This hook allows to extend the added TypoScript by adding
custom TypoScript templates (e.g. not loaded from the database)

Review

  • Code review CR +2
    • Georg Ringer +2
    • Susi Moog +1
  • Verified V +2
    • Georg Ringer +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1317

  1. Benni Mack uploaded patch set 1 01/03/17, 12:29

  2. TYPO3com voted on patch set 1 V +1 01/03/17, 12:34 Completed build in 04m 25s on Tue, 3 Jan, 01:34 PM Test Summary: 54437 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6176

  3. Georg Ringer commented on patch set 1 01/03/17, 13:01

    TemplateService.php:669

    shouldn't be the key be Core/TypoScript/TemplateService?
  4. Benni Mack commented on patch set 2 01/09/17, 08:56

    Published edit on patch set 1.
  5. TYPO3com voted on patch set 2 V +1 01/09/17, 09:00 Completed build in 03m 57s on Mon, 9 Jan, 10:00 AM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6313

  6. Georg Ringer voted on patch set 2 CR +1 V +1 01/09/17, 09:23

  7. Wouter Wolters commented on patch set 2 01/09/17, 09:25

    Feature-79140-AddHookToAddCustomTypoScriptTemplates.rst:14

    php:
  8. Benni Mack commented on patch set 3 01/09/17, 11:39

    Published edit on patch set 2.
  9. TYPO3com voted on patch set 3 V +1 01/09/17, 11:44 Completed build in 05m 05s on Mon, 9 Jan, 12:44 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6323

  10. Josef Glatz commented on patch set 3 01/09/17, 12:49

    Would it make sense to add at least an example in the rst?
  11. Benni Mack uploaded patch set 4 01/11/17, 16:35

  12. TYPO3com voted on patch set 4 V +1 01/11/17, 16:42 Completed build in 07m 22s on Wed, 11 Jan, 05:42 PM Test Summary: 54945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6497

  13. Susi Moog commented on patch set 4 01/11/17, 17:11

    Feature-79140-AddHookToAddCustomTypoScriptTemplates.rst:48

    shouldn't that be false?
  14. Benni Mack commented on patch set 4 01/11/17, 17:17

    Feature-79140-AddHookToAddCustomTypoScriptTemplates.rst:48 Reply

    Nope. It tells the TemplateService class that it was included already (e.g. by third party)
  15. Susi Moog commented on patch set 4 CR +1 V +1 01/11/17, 17:24

    Feature-79140-AddHookToAddCustomTypoScriptTemplates.rst:48 Reply

    ah, so it's defaultTypoScriptWasAlreadyAdded ;) mmkay, got it.
  16. Georg Ringer voted on patch set 4 CR +2 V +2 01/11/17, 17:37

  17. Gerrit merged patch set 4 01/11/17, 17:37