51106[FEATURE] Add hook to add custom TypoScript templates
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Susi Moog +1
-
Verified V +2
- Georg Ringer +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1317
-
Benni Mack uploaded patch set 1 01/03/17, 12:29
-
TYPO3com voted on patch set 1 V +1 01/03/17, 12:34 Completed build in 04m 25s on Tue, 3 Jan, 01:34 PM Test Summary: 54437 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6176
-
Georg Ringer commented on patch set 1 01/03/17, 13:01
-
Benni Mack commented on patch set 2 01/09/17, 08:56
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 01/09/17, 09:00 Completed build in 03m 57s on Mon, 9 Jan, 10:00 AM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6313
-
Georg Ringer voted on patch set 2 CR +1 V +1 01/09/17, 09:23
-
Wouter Wolters commented on patch set 2 01/09/17, 09:25
Feature-79140-AddHookToAddCustomTypoScriptTemplates.rst:14php: -
Benni Mack commented on patch set 3 01/09/17, 11:39
Published edit on patch set 2. -
TYPO3com voted on patch set 3 V +1 01/09/17, 11:44 Completed build in 05m 05s on Mon, 9 Jan, 12:44 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6323
-
Josef Glatz commented on patch set 3 01/09/17, 12:49
Would it make sense to add at least an example in the rst? -
Benni Mack uploaded patch set 4 01/11/17, 16:35
-
TYPO3com voted on patch set 4 V +1 01/11/17, 16:42 Completed build in 07m 22s on Wed, 11 Jan, 05:42 PM Test Summary: 54945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6497
-
Susi Moog commented on patch set 4 01/11/17, 17:11
Feature-79140-AddHookToAddCustomTypoScriptTemplates.rst:48shouldn't that be false? -
Benni Mack commented on patch set 4 01/11/17, 17:17
Feature-79140-AddHookToAddCustomTypoScriptTemplates.rst:48ReplyNope. It tells the TemplateService class that it was included already (e.g. by third party) -
Susi Moog commented on patch set 4 CR +1 V +1 01/11/17, 17:24
Feature-79140-AddHookToAddCustomTypoScriptTemplates.rst:48Replyah, so it's defaultTypoScriptWasAlreadyAdded ;) mmkay, got it. -
Georg Ringer voted on patch set 4 CR +2 V +2 01/11/17, 17:37
-
Gerrit merged patch set 4 01/11/17, 17:37
TemplateService.php:669