51116[BUGFIX] Correctly exclude non pageOverlayFields
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 6
- typo3/sysext/core/Classes/Resource/Security/StoragePermissionsAspect.php2+1 −1
- typo3/sysext/frontend/Classes/Page/PageRepository.php1+31 −1
- typo3/sysext/frontend/Tests/Functional/Fixtures/pages.xml3+1 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/sys_file.xmlnew+10 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/sys_file_reference.xmlnew+13 −0
- typo3/sysext/frontend/Tests/Functional/Page/PageRepositoryTest.php2+53 −0
Review log 1926
Show 1 earlier messages
-
Frans Saris uploaded patch set 1 01/04/17, 14:53
-
TYPO3com voted on patch set 1 V -1 01/04/17, 14:57 Completed build in 04m 09s on Wed, 4 Jan, 03:57 PM Test Summary: 8 of 54907 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6215
-
Frans Saris uploaded patch set 2 01/05/17, 13:02
-
TYPO3com voted on patch set 2 V +1 01/05/17, 13:06 Completed build in 04m 01s on Thu, 5 Jan, 02:06 PM Test Summary: 54907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6228
-
Frans Saris uploaded patch set 3 01/06/17, 15:49
-
TYPO3com voted on patch set 3 V +1 01/06/17, 15:53 Completed build in 04m 14s on Fri, 6 Jan, 04:53 PM Test Summary: 54907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6255
-
Frans Saris commented on patch set 3 01/11/17, 18:59
-
Frans Saris uploaded patch set 4 01/11/17, 20:41
-
TYPO3com voted on patch set 4 V -1 01/11/17, 20:46 Completed build in 04m 44s on Wed, 11 Jan, 09:46 PM Test Summary: 54979 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6522
-
Frans Saris commented on patch set 5 01/11/17, 20:51
Published edit on patch set 4. -
TYPO3com voted on patch set 5 V +1 01/11/17, 20:56 Completed build in 05m 16s on Wed, 11 Jan, 09:56 PM Test Summary: 54979 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6523
-
Oliver Hader uploaded patch set 6 01/11/17, 22:25
-
Oliver Hader voted on patch set 6 CR +1 01/11/17, 22:25
-
Oliver Hader voted on patch set 6 V +1 01/11/17, 22:29
-
TYPO3com voted on patch set 6 V +1 01/11/17, 22:30 Completed build in 05m 06s on Wed, 11 Jan, 11:30 PM Test Summary: 55009 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6534
-
Nicole Hummel commented on patch set 6 01/14/17, 10:23
In my opinion this is maybe a valid bugfix but I don't know if it isn't breaking as you might not get results which you get now (in 7.6). Extensions and website may rely on this "feature" and get broken with a backportStoragePermissionsAspect.php:64when does this property be empty?pages.xml:142imho this needs to go in a separate fixturepages.xml:152this needs to go in a separate fixture.PageRepositoryTest.php:337Is this the correct expectation here? if the media field is removed from the overlay, I wouldn't expect a file reference if not defined for sys_language_uid=1, would I? -
Frans Saris commented on patch set 6 01/15/17, 09:12
Regarding the backport: give this some thought and as this only affects the file references linked to a page I can only come up with 1 use-case where you could use this side-effect (by mistake). You have a file/image linked to your default language page and when you render a different language (page_language_overlay) you don't want this image and you also don't want the editor to have the BE field for page_language_overlay Not sure if this is a valid use-case in practiceStoragePermissionsAspect.php:64ReplyThe tests failed. I guess because the signal/slot is registerd during bootstrap of testing framework but $GLOBALS['BE_USER'] isn't. As this slot only needs to do something when we got a BE_USER I figured this was the safest way to resolve the failing tests.pages.xml:142ReplyGives this any benefits? or do we have guidelines for this? pages and pages_language_overlay are also in this file so I thought the idea was to have all fixtures together.PageRepositoryTest.php:337ReplyBecause it's removed from the overlay it uses the field form parent record. So in the first test is uses the overlay and there the overlay is empty and the result is 0 In this test it doesn't use the overlay and falls back the the parent record. So result is 1 -
Frans Saris uploaded patch set 7 01/17/17, 12:11
-
TYPO3com voted on patch set 7 V +1 01/17/17, 12:15 Completed build in 04m 09s on Tue, 17 Jan, 01:15 PM Test Summary: 54985 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6736
-
Jo Hasenau commented on patch set 7 CR +1 V +1 02/16/17, 11:15
This is a really annoying bug, that lead to a lot of wrong images being taken as <metag og:image /> for translated pages shared on facebook, since FB uses the first image found on the page then, which might give create wrong content. Since we use the clickstorm SEO extension for FB cards, it took me quite some time to find out that it's actually the core which is broken here. The bad thing is, that you don't expect it to behave that way and just notice the buggy behaviour when it's already too late and people started sharing stuff in the other language already. -
Mona Muzaffar commented on patch set 7 CR -1 02/24/17, 13:28
this patch is not valid for the master anymore, since the language handling changed. Also I think this issue was already fixed with this patch: https://review.typo3.org/#/c/51728/2 . So i think this can be abandoned -
Oliver Hader commented on patch set 7 03/05/17, 12:26
This change is still valid, at least for 7.6 -
Mona Muzaffar wrote 03/22/17, 14:56
Removed the following votes: * Code-Review-1 by Mona Muzaffar <mona.muzaffar@gmx.de> -
Elmar Hinz commented on patch set 7 05/12/17, 13:02
Apply, abandon or apply for 7.6 only? -
Frank Nägler commented on patch set 7 08/18/17, 14:22
patch needs a rebase -
Benni Mack abandoned the change 09/09/17, 23:25
I abandon this patch for now (for master) ... if you need this in 7.6, please create a patch for the TYPO3_7-6 branch
PageRepository.php:1942