Review main Merged

51143[BUGFIX] Render metatags on uncached pages

Daniel Dorndorf CR +2 V +2 Easy +2 −1 updated 01/24/17, 08:12

Commit message

Adding metatags on uncached pages using the pagerenderer didn't work
because the metatag array was rendered prior to adding any
entries with the 'render-preProcess' hook.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Stephan Großberndt +1
    • Frans Saris +1
    • Jörg Bösche +1
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2
    • Anja Leichsenring +2
    • Frans Saris +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1416

  1. Daniel Dorndorf uploaded patch set 1 01/05/17, 10:19

  2. TYPO3com voted on patch set 1 V +1 01/05/17, 10:22 Completed build in 03m 35s on Thu, 5 Jan, 11:22 AM Test Summary: 54907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6224

  3. Mathias Schreiber updated the commit message in patch set 2 01/05/17, 10:47

  4. TYPO3com voted on patch set 2 V +1 01/05/17, 10:51 Completed build in 03m 47s on Thu, 5 Jan, 11:51 AM Test Summary: 54907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6225

  5. Frans Saris voted on patch set 2 CR +1 01/05/17, 11:12

  6. Frans Saris commented on patch set 2 01/05/17, 11:12

    Do you maybe have some code snippet/test extension to verify this?
  7. Oliver Hader voted on patch set 2 CR +1 01/05/17, 11:29

  8. Daniel Dorndorf commented on patch set 2 01/05/17, 12:49

    > Do you maybe have some code snippet/test extension to verify this? https://typo3.org/extensions/repository/view/mindshape_seo The extension uses the pagerenderer to add the metatags, but were missed on uncached pages
  9. Frans Saris commented on patch set 2 V +1 01/05/17, 13:38

    Tested it with an extension similar to mindshape_seo and this typoscript snippet to trigger the uncached page. page.20 = USER_INT page.20 { userFunc = dummy }
  10. Stephan Großberndt voted on patch set 2 CR +1 01/05/17, 15:45

  11. Daniel Goerz voted on patch set 2 CR +1 01/06/17, 15:35

  12. Andreas Kienast voted on patch set 2 CR +1 01/07/17, 10:18

  13. Jörg Bösche voted on patch set 2 CR +1 01/07/17, 22:14

  14. Anja Leichsenring voted on patch set 2 CR +2 V +2 01/24/17, 08:11

  15. Gerrit merged patch set 2 01/24/17, 08:12

  16. Anja Leichsenring commented on patch set 3 01/24/17, 08:12

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 40c8dbe5854e66fb120265b741be454b21946aa4