51161[TASK] Properly select Chinese (Simplified) in DatePicker.js
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Frank Nägler +1
- Andreas Kienast +1
-
Verified V +2
- Christian Kuhn +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1215
-
TYPO3com uploaded patch set 1 01/06/17, 08:02
-
TYPO3com voted on patch set 1 V +1 01/06/17, 08:07 Completed build in 04m 17s on Fri, 6 Jan, 09:07 AM Test Summary: 54907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6246
-
Benni Mack commented on patch set 1 01/06/17, 10:30
Looks like you should fix this in moment.js -
David Wong commented on patch set 1 CR +1 V +1 01/07/17, 07:03
> Looks like you should fix this in moment.js Yep,it's esay way to fix this in moment.js. I have done. -
Wouter Wolters commented on patch set 1 CR -1 01/07/17, 10:37
We fetch this moment.js with bower. We can't have this fixed this way. This is a 3rd party library and the fix needs to be inlcuded in moment itself or a different solution must be found. -
David Wong commented on patch set 1 CR 0 V 0 01/07/17, 16:11
> We fetch this moment.js with bower. We can't have this fixed this > way. This is a 3rd party library and the fix needs to be inlcuded > in moment itself or a different solution must be found. I know, but translation.typo3.org used "ch"="Chinese simplified". So in moment.js never add laber "ch". ISO older Chinese simplified = zh-cn Iso newer chinese simplified = zh-hans-cn -
Reiner Teubner commented on patch set 1 CR -1 02/07/18, 10:55
The issue can't be solved on this way. I prefer to abandon this patch with the todo to fix the language marker in general corresponding to the iso norm. -
Mathias Schreiber commented on patch set 1 02/07/18, 11:32
I disagree. moment.defineLocale('en-foo', { parentLocale: 'en' }); would be the fix. See https://github.com/moment/moment/pull/2774 -
Mathias Schreiber commented on patch set 1 02/07/18, 11:48
@David Wong: Can you provide us with a bit of description of the error itself? What does not work? -
Mathias Schreiber uploaded patch set 2 02/07/18, 12:25
-
Andreas Kienast voted on patch set 2 CR +1 02/07/18, 12:26
-
Frank Nägler voted on patch set 2 V +1 CR +1 02/07/18, 12:27
-
TYPO3com voted on patch set 2 V +1 02/07/18, 12:33 Completed build in 08m 17s on Wed, 7 Feb, 01:33 PM Test Summary: 30458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19072
-
Christian Kuhn voted on patch set 2 V +2 CR +2 02/07/18, 12:36
-
Christian Kuhn merged patch set 3 02/07/18, 12:36