Review main Abandoned

51162[CLEANUP] Moving schedule user creation to dedicated service class

Christian Müllenhagen CR 0 V 0 Hard +375 −68 updated 01/10/17, 23:53

Commit message

Moving the schedule user creation to a dedicated class and adding functional tests.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 6

Review log 814

  1. Christian Müllenhagen uploaded patch set 1 01/06/17, 08:20

  2. Christian Müllenhagen uploaded patch set 2 01/06/17, 08:21

  3. TYPO3com voted on patch set 1 V -1 01/06/17, 08:25 Completed build in 04m 47s on Fri, 6 Jan, 09:25 AM Test Summary: 6 of 54913 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6247

  4. TYPO3com voted on patch set 2 V -1 01/06/17, 08:26 Completed build in 04m 43s on Fri, 6 Jan, 09:26 AM Test Summary: 54913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6248

  5. Christian Müllenhagen updated the commit message in patch set 3 01/06/17, 08:38

  6. TYPO3com voted on patch set 3 V -1 01/06/17, 08:42 Completed build in 03m 37s on Fri, 6 Jan, 09:42 AM Test Summary: 54913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6249

  7. Christian Müllenhagen uploaded patch set 4 01/06/17, 08:52

  8. TYPO3com voted on patch set 4 V -1 01/06/17, 08:56 Completed build in 04m 18s on Fri, 6 Jan, 09:56 AM Test Summary: 54913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6250

  9. Christian Müllenhagen uploaded patch set 5 01/06/17, 08:58

  10. TYPO3com voted on patch set 5 V +1 01/06/17, 09:02 Completed build in 03m 54s on Fri, 6 Jan, 10:02 AM Test Summary: 54913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6251

  11. Christian Müllenhagen uploaded patch set 6 01/09/17, 16:38

  12. TYPO3com voted on patch set 6 V +1 01/09/17, 16:43 Completed build in 04m 26s on Mon, 9 Jan, 05:43 PM Test Summary: 54927 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6343

  13. Morton Jonuschat abandoned the change 01/10/17, 23:47

    _cli_scheduler user and related functionality has been removed in Ie2472869b9db1fc9dcb4add9fae6be63722156c6
  14. Christian Kuhn commented on patch set 6 01/10/17, 23:53

    Christian, thanks for your patch. Unfortunately, you picked up a functionality Benni was heavily working on through the v8 development. His work just finished with the default _cli_ user who has admin rights and is always initialized on cli level. The code you're moving around doesn't exist anymore. And yes, it was ugly code that mixed up stuff into SchedulerModuleController that shouldn't belong there, your approach was good and ok. However, the patch is obsolete now and I hope you accept if we abandon it.