Review main Merged

51202[TASK] ext:beuser delete button title attribute

Josef Glatz CR +2 V +2 Easy +4 −0 updated 01/09/17, 12:25

Commit message

Add missing title attribute to delete button in the backend user
listing module.

Review

  • Code review CR +2
    • Benni Mack +2
    • Daniel Goerz +1
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1013

  1. Josef Glatz uploaded patch set 1 01/08/17, 21:20

  2. TYPO3com voted on patch set 1 V +1 01/08/17, 21:24 Completed build in 03m 32s on Sun, 8 Jan, 10:24 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6302

  3. Josef Glatz updated the commit message in patch set 2 01/09/17, 06:35

  4. Josef Glatz updated the commit message in patch set 3 01/09/17, 06:36

  5. TYPO3com voted on patch set 2 V +1 01/09/17, 06:40 Completed build in 04m 45s on Mon, 9 Jan, 07:40 AM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6309

  6. TYPO3com voted on patch set 3 V +1 01/09/17, 06:40 Completed build in 04m 54s on Mon, 9 Jan, 07:40 AM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6310

  7. Wouter Wolters voted on patch set 3 CR +1 01/09/17, 08:05

  8. Benni Mack commented on patch set 3 01/09/17, 09:06

    RemoveUserViewHelper.php:86

    shouldn't we use this data-title attribuet for "title"?
  9. Josef Glatz commented on patch set 3 01/09/17, 11:52

    As you like Benni! The important thing is to have a meaningful title attribute. Let me know if I should change it :-]
  10. Benni Mack commented on patch set 3 CR +1 V +1 01/09/17, 12:19

    ah, no, that's fine. double checked the XLF. all fine.
  11. Daniel Goerz voted on patch set 3 CR +1 V +1 01/09/17, 12:24

  12. Benni Mack voted on patch set 3 CR +2 V +2 01/09/17, 12:25

  13. Gerrit merged patch set 3 01/09/17, 12:25